Opened 7 years ago

Closed 6 years ago

#338 closed defect (fixed)

PostGIS defect : insert with srid -1 failed

Reported by: bscott Owned by:
Priority: blocker Milestone: 3.4.0
Component: PostGIS Provider Version: 3.3.0
Severity: 1 Keywords: srid srs epsg
Cc: External ID:

Description

While i have fixed the insert with srid != -1 i discover that the default srid in the GetSRID() function was 0. So it need to be changed to -1

Attachments (2)

postgis_trunk_338.patch (1.3 KB) - added by mloskot 7 years ago.
Patch from Bruno Scott
postgis_trunk_338_2.patch (585 bytes) - added by bscott 7 years ago.
second patch for ticket 338 reopened

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by mloskot

Patch from Bruno Scott

comment:1 Changed 7 years ago by mloskot

  • Keywords srid srs epsg added
  • Status changed from new to assigned

comment:2 Changed 7 years ago by mloskot

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in trunk (r3949). Thanks Bruno!

comment:3 Changed 7 years ago by bscott

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:4 Changed 7 years ago by bscott

The fix has broken something, it does not find srid if it's not -1 As currentSrid was defaulted to 0 this line was ok

for (FdoInt32 i = 0; !currentSrid && i < propsDef->GetCount?()); i++)

Now that the default srid is -1 we need to update the for loop as this :

for (FdoInt32 i = 0; ((currentSrid == -1) && i < propsDef->GetCount?()); i++)

Changed 7 years ago by bscott

second patch for ticket 338 reopened

comment:5 Changed 6 years ago by bscott

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:6 Changed 6 years ago by mloskot

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:7 Changed 6 years ago by mloskot

  • Owner mloskot deleted
  • Status changed from reopened to new

comment:8 Changed 6 years ago by mloskot

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.