Opened 11 years ago

Closed 11 years ago

#160 closed defect (fixed)

CS-Map requires grid source (ascii) files to be around even though it never needs them (as per ticket 151)

Reported by: baertelchen Owned by: baertelchen
Priority: minor Milestone:
Component: Dictionaries Version:
Keywords: skip recompilation of ascii grid files Cc:

Description

Ticket 151 (http://trac.osgeo.org/csmap/ticket/151) aimed for not having CS-Map recompiling certain grid files on every access.

The fix for this ticket had been in a way incomplete that it still requires the ascii files to be around even though they are actually never needed.

With this ticket, the code in CS-Map should be changed so it does not require the "source" grid files to be available, if the binaries exist already.

Following grid files are affected:
OSTN02.txt
OSTN97.TXT
TKY2JGD.par
JGD2011V100.par

Note, that pre-compiling these grid files with the build has to be addressed through a different ticket.

Change History (1)

comment:1 by baertelchen, 11 years ago

Resolution: fixed
Status: newclosed

Fixed in changest 2336 (http://trac.osgeo.org/metacrs/changeset/2336).

Modified the code in CS_japanNew.c, CS_ostn02.c, CS_ostn97.c and CS_trmer.c so that the following ASCII-typed grid files are no longer explicitly required to exist, if their binary counterparts exist already:

OSTN02.txt OSTN97.TXT TKY2JGD.par JGD2011V100.par

The logic has been changed, so that the binary files (e.g. OSTN02._02) are checked first (e.g. via CS_access(file, mode)), and only if not existing, the ASCII files are verified to exist, too (so that CS-Map can recompile the files on a as-need basis). If someone needs to modify the source grid files, the binaries have to be deleted before re-running CS-Map.

Changes reviewed by Andreas.

Note: See TracTickets for help on using tickets.