Opened 17 years ago

Closed 16 years ago

Last modified 15 years ago

#989 closed patch (fixed)

Action with Capture output disabled appears to do nothing

Reported by: smizuno Owned by: gsherman
Priority: major: does not work as expected Milestone:
Component: MapCanvas Version: Trunk
Keywords: action Cc:
Must Fix for Release: No Platform: All
Platform Version: Awaiting user input: no

Description

Action with Capture output disabled appears to do nothing when activated (Linux and Windows; don't know about Mac).

  1. set up an Action to start Firefox, for example (doesn't matter what program is used); don't enable Capture output
  2. Identify an object on the canvas, then click the action item in the Identify Results dialog - no window for the program appears.

If Capture output is enabled, then the dialog to show the results of the program appears and the program window appears as expected.

This used to work on 0.8.1

Attachments (1)

patch_for_bug_989.txt (1.3 KB ) - added by smizuno 16 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 by smizuno, 16 years ago

Milestone: Version 1.0Version 0.9.2
Type: defectpatch

I am submitting a patch to fix this problem. This is the cause: the process is started, then immediately killed by die() if the process is not captured.

The details:

1.merged the two

if (capture)

code blocks where the process is started for capturing

  1. used QProcess::startDetached() to start the non-captured process
  1. on failure to start the non-captured process a message box is raised to inform the user

I have tested this on Linux and Windows XP.

by smizuno, 16 years ago

Attachment: patch_for_bug_989.txt added

comment:2 by gsherman, 16 years ago

Owner: changed from nobody to gsherman

comment:3 by gjm, 16 years ago

Resolution: fixed
Status: newclosed

Applied in r8989. Thanks.

comment:4 by (none), 15 years ago

Milestone: Version 1.0.0

Milestone Version 1.0.0 deleted

Note: See TracTickets for help on using tickets.