Opened 16 years ago

Closed 13 years ago

#926 closed bug (fixed)

identify tool: features highlited wrong when a polygon inside a polygon is presnt

Reported by: msieczka Owned by: timlinux
Priority: major: does not work as expected Milestone: Version 1.7.0
Component: Vectors Version: Trunk
Keywords: Cc: pcav, mhugent, lutra, timlinux
Must Fix for Release: No Platform: All
Platform Version: Awaiting user input: no

Description

Look at the attached screendumps.

Black arrow points at the polygon being queried.

identify_bad.png shows how it is now. This is wrong - although the smaller polygon inside is not being queried, it looks like if it was too.

identify_ok.png shows how it should look like - it is clear which polygon is queried actually.

Attachments (5)

identify_bad.png (12.5 KB ) - added by msieczka 16 years ago.
as it looks now - wrong
identify_ok.png (12.2 KB ) - added by msieczka 16 years ago.
as it should look - OK
Screenshot.png (134.0 KB ) - added by lutra 14 years ago.
Screenshot-1.png (134.5 KB ) - added by lutra 14 years ago.
Screenshot-2.png (133.7 KB ) - added by lutra 14 years ago.

Download all attachments as: .zip

Change History (15)

by msieczka, 16 years ago

Attachment: identify_bad.png added

as it looks now - wrong

by msieczka, 16 years ago

Attachment: identify_ok.png added

as it should look - OK

comment:1 by timlinux, 16 years ago

Milestone: Version 1.0Version 0.11.0
Owner: changed from nobody to timlinux
Status: newassigned

comment:2 by timlinux, 16 years ago

Milestone: Version 0.11.0Version 1.0.0

I had a detailed look at this. The issue lies inside QgsRubberBand. The polygon drawing routine in that class iterates over multipolygons, but not rings. It will be possible to add this functionality (and I agree we should) but I dont think its a good idea to make the invasive changes required right at the end of code freeze / on the point of release. I'm moving this issue over to milestone 1.0.0 and I'll attend to it in the next release cycle.

Regards

Tim

comment:3 by lutra, 15 years ago

Cc: pcav added

Hi, I gave a try to this on qgis 1.2 (rev. 10988).

If the select tool is used on the outer polygon it selects just it, using the tool on the inner one, it selects both.

This means that this bug has already been fixed?

comment:4 by lutra, 15 years ago

Milestone: Version 1.0.3Version 1.2.0
Platform: DebianAll

I noticed that by selecting the proper row (the one of the inner polygon) in the attribute table, it possible to select just the inner or the outer polygon. The select tools does not behave the same, so I guess this is still to fix. Nevertheless should be easy. Pushing the milestone to 1.2.

comment:5 by lutra, 15 years ago

Well,

if Qgis is doing it wrong it is not alone. I just tested gvSIG 1.2 and it behaves exactly the same way (see may last two comments).

So, please leave feedback, if this is the right behaviour we can close the ticket.

comment:6 by lutra, 15 years ago

Cc: mhugent added
Owner: changed from timlinux to lutra
Status: assignednew

comment:7 by lutra, 15 years ago

Owner: changed from lutra to timlinux

comment:8 by lutra, 14 years ago

Resolution: fixed
Status: newclosed

I believe that this can be closed now. See attached screenshots to see how it worls the identify tool now.

Clicking on the outer polygon it kind of highlight also the inner one, but the result window do not show it. Moreover if you click again on the inner polygon it will get a more dense color and the result appear in the result windows.

Then if you click on the proper result in the result window you'll get highlighted just the inner one.

by lutra, 14 years ago

Attachment: Screenshot.png added

by lutra, 14 years ago

Attachment: Screenshot-1.png added

by lutra, 14 years ago

Attachment: Screenshot-2.png added

comment:9 by imincik1, 13 years ago

Cc: lutra timlinux added
Milestone: Version 1.4.0Version 1.7.0
Must Fix for Release: YesNo
Resolution: fixed
Status: closedreopened

I am reopening this ticket, because of the behavior of 'identify tool' in current trunk which is the same as in 'identify_bad.png' picture.

Ticket #2190 is duplicate to this issue. There was also thread in mailinglist [1].

[1] - http://www.mail-archive.com/qgis-developer@lists.osgeo.org/msg02031.html

comment:10 by jef, 13 years ago

Resolution: fixed
Status: reopenedclosed

fixed in 15315.

Note: See TracTickets for help on using tickets.