Opened 13 years ago

Last modified 13 years ago

#3572 new patch

Handling of symbology load error on project load

Reported by: ccrook Owned by: nobody
Priority: critical: causes crash or data corruption Milestone: Version 1.7.0
Component: Project Loading / Saving Version: Trunk
Keywords: project file load error Cc:
Must Fix for Release: No Platform: All
Platform Version: Awaiting user input: no

Description

This is a proposed patch to change the behaviour of QGis if a layer fails to load because it cannot process the symbology definition in the project file (eg because a renderer plugin is missing).

The current behaviour is to fail to load the layer. The attached patch changes this to instead use a default symbology.

Neither is ideal ... I think it would be better to load a default symbology and report to the user that the original symbology could not be loaded - preferably with a reason why. However that raises a bigger question about how to handle errors when loading the project file.

At the moment if the symbology doesn't load, the layer fails, and the user is presented with the bad layers handler. This allows them to reselect the file used by the layer. However this is really confusing if the file is correct and exists, but the symbology cannot be loaded ... it confused me anyway!

With this patch the layer loads, but the symbology reverts to a default definition - not what the user would expect, but the best that can be done.

Attachments (1)

symbology_read_error_fix.diff (1.1 KB ) - added by ccrook 13 years ago.

Download all attachments as: .zip

Change History (3)

by ccrook, 13 years ago

comment:1 by ccrook, 13 years ago

Type: bugpatch

comment:2 by pcav, 13 years ago

Component: Build/InstallProject Loading / Saving
Note: See TracTickets for help on using tickets.