Opened 14 years ago

Closed 14 years ago

#2159 closed patch (fixed)

Page Setup menu item for Mac os printing

Reported by: vrgsmm01 Owned by: mhugent
Priority: major: does not work as expected Milestone: Version 1.5.0
Component: Printing Version: Trunk
Keywords: printing Cc:
Must Fix for Release: No Platform: OS X
Platform Version: Awaiting user input: no

Description

Page Setup menu item must be added in file menu for MacOS printing correctly

Attachments (1)

bug2159fix.diff (3.9 KB ) - added by ctimko 14 years ago.
Patch generated by SVN in Eclipse

Download all attachments as: .zip

Change History (13)

comment:1 by pcav, 14 years ago

Component: Build/InstallPrinting

comment:2 by pcav, 14 years ago

Component: PrintingGUI

comment:3 by jctull, 14 years ago

I would like to second the call to fix this. As things currently stand in OS X, you have to save a composer project as an image, then go to another program to print the file. Currently, qgis defaults to the standard letter size (likely based on locale) on OS X and there is no widget to change the paper format, as in the dialog on linux systems. So on my system, it will go through the render process, but only produce a print file for the first 8.5x11 inches of you print image.

For reference, see: http://doc.trolltech.com/4.5/qpagesetupdialog.html

comment:4 by ctimko, 14 years ago

Verify this ticket is identical to this ticket -> #2425

comment:5 by jctull, 14 years ago

Yes, this ticket and #2425 are the same. I would suggest bringing the description from 2425 over here before closing 2425.

comment:6 by ctimko, 14 years ago

Owner: changed from nobody to ctimko
Status: newassigned

"When you try to print from the composer...if the layout paper is bigger than A4

...print result is out of range.

This problem can be fixed by adding an additional menu idem "page setup" in macos version otherwise can't print layouts in plotter...because page setup doesn't work properly.

In version 0.74 the page setup is working perfectly...because if the composer map paper is different from the printing paper...the "page setup dialog" is appearing asking you to choose the appropriate page and printer for printing!

Now...in current version 1.4 this feature is not present...why???" ~ #2425

Patch ready for this as well.

by ctimko, 14 years ago

Attachment: bug2159fix.diff added

Patch generated by SVN in Eclipse

comment:7 by ctimko, 14 years ago

Component: GUIPrinting
Type: enhancementpatch

comment:8 by jctull, 14 years ago

I confirmed the patch worked on my trunk build. Good work!

comment:9 by jef, 14 years ago

Owner: changed from ctimko to mhugent
Status: assignednew

comment:10 by mhugent, 14 years ago

The patch looks good. I didn't realize there is a problem with the page dialog on MacOS. I have only two minor comments:

  • The deletes are missing (or creat objects on the stack)
  • Is it intentional that the page setup dialog is modeless (show() instead of exec() ) ?. Because now, the user could open a lot of page setup dialogs at the same time.

Regards, Marco

comment:11 by jctull, 14 years ago

Hi Marco. This patch was assigned to you when submitted, so it was assumed that you knew. Unfortunately, there are numerous others assigned to you related to print composer, so perhaps a review of what is open is in order.

Regarding the modeless setting, the page setup dialog is exposed as a sheet rather than a separate dialog, so I don't think it is possible to have more than one at a time. I could not get it to do so anyway. I have noticed an occasional disappearing print dialog, but I do not know if this is in any way related.

comment:12 by mhugent, 14 years ago

Resolution: fixed
Status: newclosed

Applied in r13545 with the mentioned modifications. Thanks ctimko!

Note: See TracTickets for help on using tickets.