Changes between Version 24 and Version 25 of DevWikiComitGuidelines


Ignore:
Timestamp:
Feb 24, 2011, 5:12:03 AM (10 years ago)
Author:
robe
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • DevWikiComitGuidelines

    v24 v25  
    11= RFC ? : PostGIS Committer Guidelines =
    2 '''Version''': 1.00000002
    3 
     2'''Version''': 1.00000003
    43'''Status''': draft
    54
     
    4342    * Use meaningful descriptions for commit log entries.
    4443    * Add a bug reference like "(#1232)" at the end of SVN commit log entries when committing changes related to a ticket in Trac. The '#' character enables Trac to create a hyperlink from the changeset to the mentionned ticket.
    45     * Add a note HISTORY to the commit log if this is a major feature that should be noted in the NEWS version release and credits
     44    * When new enhancements are added or breaking changes are made, these should be noted in the trunk/NEWS or relevant branch/NEWS as soon as conveniently possible.  The note should include the trac # and contributors to the feature/change
    4645    * After commiting changes related to a ticket in Trac, write the tree and revision in which it was fixed in the ticket description. Such as "Fixed in trunk (r12345) and in branches/1.7 (r12346)". The 'r' character enables Trac to create a hyperlink from the ticket to the changeset.
    4746    * Changes should not be committed in stable branches without a corresponding bug id. Any change worth pushing into the stable version is worth a bug entry.
     
    5150    * Significant changes to the main development version should be discussed on the postgis-dev list before you make them, and larger changes will require an RFC approved by the PSC.
    5251    * Do not create new branches (except for spike branches) without the approval of the PSC. Release managers are assumed to have permission to create a branch.
    53     * spike branche (htose in the spike/username area are to be used for experimentation of for major code refactorings that will destabilize the trunk.  After
    54 such experimentation is stable, this can then be merged into the trunk after approval from PSC members.
     52    * spike branch (those in the spike/username area are to be used for experimentation or for major code refactorings that will destabilize the trunk.  After such experimentation is stable, this can then be merged into the trunk after approval from PSC members.
    5553    * All source code in SVN should be in Unix text format as opposed to DOS text mode.
    5654    * C code should follow our designated A-style format and astyle should be applied before commit
    5755    * When committing new features or significant changes to existing source code, the committer should take reasonable measures to insure that the source code continues to build and work on the most commonly supported platforms (currently Linux and Windows), either by testing on those platforms directly, running Buildbot tests, or by getting help from other developers working on those platforms. If new files or library dependencies are added, then the configure.in, Makefile.in, Makefile.vc and related documentations should be kept up to date.
    58     * In the event of buildbot failure notice, the person who caused the break must fix the break before working on anything else
     56    * In the event of broken build (build bot fail notification), the person who broke the build must fix the break before working on anything else
    5957
    6058== Relationship with other Projects ==