Compilation warning: uninitialized variable

[Laurenz Albe]

Building master, I get

In file included from mvt.h:40,
                 from mvt.c:30:
mvt.c: In function ‘mvt_clip_and_validate_geos’:
mvt.c:884:41: warning: ‘bgbox.flags’ may be used uninitialized [-Wmaybe-uninitialized]
  884 |                 FLAGS_SET_GEODETIC(bgbox.flags, 0);
../liblwgeom/liblwgeom.h:175:95: note: in definition of macro ‘FLAGS_SET_GEODETIC’
  175 | #define FLAGS_SET_GEODETIC(flags, value) ((flags) = (value) ? ((flags) | LWFLAG_GEODETIC) : ((flags) & ~LWFLAG_GEODETIC))
      |                                                                                               ^~~~~
mvt.c:881:22: note: ‘bgbox’ declared here
  881 |                 GBOX bgbox;
      |                      ^~~~~

Indeed, in postgis/mvt.c, bgbox.flag is not initialized:

GBOX bgbox;
bgbox.xmax = bgbox.ymax = (double)extent + (double)buffer;
bgbox.xmin = bgbox.ymin = -(double)buffer;
FLAGS_SET_GEODETIC(bgbox.flags, 0);

I guess it should be initialized to zero, as in the following patch:

postgis/mvt.c

@@ -881 +881 @@
        GBOX bgbox;
        bgbox.xmax = bgbox.ymax = (double)extent + (double)buffer;
        bgbox.xmin = bgbox.ymin = -(double)buffer;
+       bgbox.flags = 0;
        FLAGS_SET_GEODETIC(bgbox.flags, 0);
 
        ng = mvt_unsafe_clip_by_box(ng, &bgbox);