Context Navigation

Changes between Initial Version and Version 1 of Ticket #5392, comment 5

-              initial
+              v1
 select st_union(a.geom, b.geom)
 from polys a
 cross join polys b
 where a.name = 'kpc' and b.name = 'tonga';
+  from polys a
+  cross join polys b
+  where a.name = 'kpc' and b.name = 'tonga';
 }}}
 …
 {{{
 insert into polys
 select name || ' valid', st_makevalid(geom) as geom
 from polys
 where name in ('kpc', 'tonga');
+  select name || ' valid', st_makevalid(geom) as geom
+  from polys
+  where name in ('kpc', 'tonga');
 select st_area(st_union(geom)) from polys where name ~ 'valid';
 select st_area(st_union(a.geom, b.geom))
 from polys a
 cross join polys b
 where a.name = 'kpc valid'
 and b.name = 'tonga valid'
+  from polys a
+  cross join polys b
+  where a.name = 'kpc valid'
+  and b.name = 'tonga valid'
 }}}
 …
 {{{
 select st_area(st_union(a.geom, b.geom))
 from polys a
 cross join polys b
 where a.name = 'kpc'
 and b.name = 'tonga'
+  from polys a
+  cross join polys b
+  where a.name = 'kpc'
+  and b.name = 'tonga'
 }}}
 …
 I sometimes wonder if we should do automagical makevalid as part of the try/catch block on the overlay code, so the case of the TopologyException would end up actually working, automagically (catch exception, make valid, retry). But seeing the silent failure of the pairwise code makes me question that. Automagical makevalid would make those cases of silent failure even more likely to just slide by people's notice.