Opened 2 years ago
Closed 20 months ago
#5304 closed patch (fixed)
Build error: DecodeDateTime changed signature in PostgreSQL v16
| Reported by: | laurenz | Owned by: | pramsey |
|---|---|---|---|
| Priority: | blocker | Milestone: | PostGIS 3.3.3 |
| Component: | build | Version: | master |
| Keywords: | Cc: |
Description
PostgreSQL commit 2661469d86 added a new parameter to DecodeDateTime to report problems with the time zone name. This makes the PostGIS build fail.
Attached is a patch to fix that. It is not really pretty, and I am not sure if it is a good idea to ignore that diagnostic, as it used to throw an error in older PostgreSQL versions. On the other hand, the return code from DecodeDateTime is ignored anyway…
Attachments (1)
Change History (5)
by , 2 years ago
| Attachment: | 0001-Fix-DecodeDateTime-calls-for-PostgreSQL-v16.patch added |
|---|
comment:1 by , 2 years ago
| Owner: | changed from to |
|---|---|
| Priority: | low → blocker |
I think pramsey is working on this as part of his backport to PostGIS 3.3.
https://github.com/postgis/postgis/pull/716
I'll alert him of this associated ticket.
comment:2 by , 2 years ago
I was wondering why I wasn't seeing any error on master for this. Looks like this has already been applied to master (PostGIS 3.4), so only needs applying fo rPostGIS 3.3 because someone wants to support PG16 on 3.3
comment:3 by , 2 years ago
Yes, this has been added in 4dfc3f42e1.
I leave it to you to close the ticket or do a backpatch to 3.3 and lower.
comment:4 by , 20 months ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Committed to postgis 3.3.3 also at [76f44dea83e09101c2fa949b0ad8bfb00494449b/git]
Patch that fixes the build for me