Memory Leak in GEOS conversion with EMPTY

[pramsey]

The CI is showing a leak somewhere around the recent work on GEOS conversions and EMPTY geometries.

​https://travis-ci.org/github/pramsey/postgis/jobs/752331218

[Sandro Santilli <strk@…>]

In dd5c269/git:

Avoid listing the same geometry in different collections

References #4823 in master branch (3.2.0dev)

[strk]

Paul this is now fixed in master branch, please confirm before I backport to 3.1

[pramsey]

Looks like it got most of them, but there's now two crashers…

​https://travis-ci.org/github/pramsey/postgis/jobs/752589298#L2235 ​https://travis-ci.org/github/pramsey/postgis/jobs/752589299#L2234

Maybe related to GEOS 3.6 in some way?

​https://travis-ci.org/github/pramsey/postgis/builds/752589288

[strk]

I see the crashing thing references #3579 - Paul you even found a GEOS reproducer there but then there's no link to a GEOS ticket about it. The CI is running GEOS: 3.6.4dev-CAPI-1.10.4 6775f76 - can you file a ticket there ? Maybe even add a link to it from #3579

[strk]

Oh, I just realized: a crash in GEOS-3.6 I've fixed in 3.6.6dev so 3.6.4dev would NOT have such fix. Can you upgrade the CI bot to use a more recent GEOS version ? We released 3.6.5 final with that fix.

[strk]

This is the GEOS commit, for reference: ​https://git.osgeo.org/gitea/geos/geos/commit/e7caa33f69314fe4e3b9b0cee23eb9ca10ceb932

[Sandro Santilli <strk@…>]

In 051978b/git:

Avoid listing the same geometry in different collections

Closes #4823 in 3.1 branch (3.1.1dev)