Changes between Initial Version and Version 1 of Ticket #4705, comment 6


Ignore:
Timestamp:
Jun 18, 2020, 3:02:12 AM (4 years ago)
Author:
zezzagio

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4705, comment 6

    initial v1  
    33If a <input>.shp.expected exists, the sub run_dumper_and_check_output is indeed called, without the -m parameter; and would fail (that's a start), if a .dbf.expected file was compared with the result, which is not. Only the .shp.expected is considered.
    44
    5 The sub run_dumper_test is more promising, and seems to compare all the shape files. It is called if a ${TEST}.dmp file exists, from which it reads the parameters; but only as the last parameter of pgs1l2shp, that is the [table|query] argument. This goes after the [database] argument in the call, thus it can't be used to pass the -m option.
     5The sub run_dumper_test is more promising, and seems to compare all the shape files. It is called if a ${TEST}.dmp file exists, from which it reads the parameters; but only as the last parameter of pgsql2shp, that is the [table|query] argument. This goes after the [database] argument in the call, thus it can't be used to pass the -m option.
    66
    77Modifying run_dumper_test in order to take in account the custom options is not a big thing, of course, but I'm not very confident to be able to do it without breaking something.