Opened 5 years ago

Closed 5 years ago

#4596 closed defect (fixed)

The script to generate nation_script_load.sh is missing a trailing quote

Reported by: llimllib Owned by: robe
Priority: medium Milestone: PostGIS 3.0.1
Component: tiger geocoder Version: 2.5.x -- EOL
Keywords: tiger geocoder Cc:

Description

The script that generates nation_script_load.sh is missing a trailing comma at the end of this line:

https://github.com/postgis/postgis/blob/master/extras/tiger_geocoder/tiger_loader_2019.sql#L315

As a result, it generates an invalid script and the user manually has to insert a quote there.

I would be happy to generate a PR, but somebody would need to tell me how to do so, I'm unfamiliar with your dev process and it seems pretty different from a normal github process.

Change History (7)

comment:1 by llimllib, 5 years ago

Summary: The script to generate nation_script_load.sh is missing a trailing commaThe script to generate nation_script_load.sh is missing a trailing quote

comment:2 by robe, 5 years ago

Component: postgistiger geocoder
Owner: changed from pramsey to robe

comment:3 by robe, 5 years ago

Milestone: PostGIS 2.5.4PostGIS 3.0.1

comment:4 by robe, 5 years ago

you can do a github pull request is fine or a diff patch. Whatever you prefer.

comment:6 by Regina Obe <lr@…>, 5 years ago

In 41475b02/git:

Fix missing quote nation_script. References #4596 for PostGIS 3.0.1

Version 0, edited 5 years ago by Regina Obe <lr@…> (next)

comment:7 by robe, 5 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.