Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#3950 closed defect (fixed)

PostGIS trunk doesn't compile against 9.5

Reported by: robe Owned by: pramsey
Priority: blocker Milestone: PostGIS 2.5.0
Component: postgis Version: master
Keywords: Cc:

Description (last modified by robe)

I guess we can't use the ALLOC small sizes for 9.5

This is showing on winnie's 9.5 tests

prototypes  -c -o lwgeom_transform.o lwgeom_transform.c
lwgeom_transform.c: In function 'AddToPROJ4SRSCache':
lwgeom_transform.c:545:42: error: 'ALLOCSET_SMALL_SIZES' undeclared (first use in this function)
                                          ALLOCSET_SMALL_SIZES);
                                          ^
lwgeom_transform.c:545:42: note: each undeclared identifier is reported only once for each function it appears in
lwgeom_transform.c:545:42: error: too few arguments to function 'AllocSetContextCreate'
In file included from lwgeom_transform.c:18:0:
E:/jenkins/postgresql/rel/pg9.5w64gcc48/include/server/utils/memutils.h:131:22: note: declared here
 extern MemoryContext AllocSetContextCreate(MemoryContext parent,
                      ^
Makefile:61: recipe for target 'lwgeom_transform.o' failed
make[1]: *** [lwgeom_transform.o] Error 1
make[1]: Leaving directory '/projects/postgis/branches/2.5/libpgcommon'
GNUmakefile:16: recipe for target 'all' failed
make: *** [all] Error 1

So I guess 1 of two options, we can IF DEF for 9.5 or just have 9.5 go down the yee old path like 9.4

Change History (5)

comment:1 by robe, 7 years ago

Description: modified (diff)

comment:2 by robe, 7 years ago

Summary: PostGIS trunk doesn't work against 9.5PostGIS trunk doesn't compile against 9.5

comment:3 by pramsey, 7 years ago

Sending it down the old path seems preferable to figuring out a 9.5-only solution to the allocset issue.

comment:4 by robe, 7 years ago

Well I think I know the 9.5-only solution I think it just has to have the multiple-args spit out I originally thought we needed for < 11, but it's probably safer to just send it down the old path, cause otherwise we'd have an extra IFDEF ugliness we'd have to get rid of eventually.

comment:5 by robe, 7 years ago

Resolution: fixed
Status: newclosed

In 16189:

Change new cache behavior to require > 9.6 instead of > 9.5, the AllocSetContextCreate structure in 9.5 doesn't support ALLOCSET_SMALL_SIZES macro so would otherwise require more ugly ifdefing.
Closes #3950

Last edited 7 years ago by robe (previous) (diff)
Note: See TracTickets for help on using tickets.