Changes between Initial Version and Version 1 of Ticket #3852, comment 1


Ignore:
Timestamp:
09/19/17 13:59:33 (7 years ago)
Author:
pramsey

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3852, comment 1

    initial v1  
    11I found a regression failure when I ran my fix for this ticket, but the problem appears to be in the *existing* behavior, not mine...
    22
    3 When adding a box to POINT(1e+15 1e+15), aka POINT(1000000000000000 1000000000000000) the regression suite says the result of the ST_BoundingDiagonal should be LINESTRING(999999986991104 999999986991104,999999986991104 999999986991104)
     3When adding a box to `POINT(1e+15 1e+15)`, aka `POINT(1000000000000000 1000000000000000)` the regression suite says the result of the ST_BoundingDiagonal should be `LINESTRING(999999986991104 999999986991104,999999986991104 999999986991104)`
    44
    5 Wait a sec, that box doesn't enclose the original point! Huge fail! My new code does enclose it, with LINESTRING(999999986991104 999999986991104,1.00000005409997e+15 1.00000005409997e+15).
     5Wait a sec, that box doesn't enclose the original point! Huge fail! My new code does enclose it, with `LINESTRING(999999986991104 999999986991104,1.00000005409997e+15 1.00000005409997e+15)`.
    66
    77I wouldn't ordinarily commit a fix that changes regression so late in the day, but in this case, it seems an improvement. Hopefully the other platforms agree.