Opened 7 years ago
Last modified 7 years ago
#3786 closed defect
OSS FUZZ fixes — at Initial Version
Reported by: | robe | Owned by: | pramsey |
---|---|---|---|
Priority: | medium | Milestone: | PostGIS 2.2.7 |
Component: | postgis | Version: | master |
Keywords: | Cc: |
Description
I've started an attempt to resolve OSS FUZZ complaints.
Pull request here, for your input.
https://git.osgeo.org/gogs/postgis/postgis/pulls/15
strk doesn't think my change should have made a difference but I tested two times. without the change segmentation fault with change no segmentation fault.
My assumption is because the *_cp functions do more checking and internal does pretty much none.
In hind-sight I probably could have achieved the same affect by swapping out calls to getPoint2d_internal with getPoint2d_cp without having to resort to declaring POINT2D variables.
I still need to get the extra CPP flags enabled to confirm I got all the issues in this bug ticket.
https://oss-fuzz.com/v2/testcase-detail/4733660446064640?noredirect=1
Since it complained about others