PostGIS topology failures on PostgreSQL 10

[robe]

After I was done fixing all the raster issues with PostgreSQL 10, surprise surprise. topology has issues too.

Creating database 'postgis_reg'
Loading PostGIS into 'postgis_reg'
Loading Topology into 'postgis_reg'
PostgreSQL 10beta1 on x86_64-w64-mingw32, compiled by gcc.exe (x86_64-win32-seh-rev4, Built by MinGW-W64 project) 4.9.2, 64-bit
  Postgis 2.4.0dev - r15404 - 2017-05-26 06:16:27
  scripts 2.4.0dev r15404
  GEOS: 3.7.0dev-CAPI-1.11.0 8fe2ce6
  PROJ: Rel. 4.9.1, 04 March 2015

Running tests

 regress/legacy_validate .. ok
 regress/legacy_predicate .. ok
 regress/legacy_invalid .. ok
 regress/sqlmm .. ok
 regress/legacy_query .. ok
 regress/addnode .. ok
 regress/addedge .. ok
 regress/addface .. ok
 regress/addface2.5d .. ok
 regress/addtopogeometrycolumn .. ok
 regress/polygonize .. ok
 regress/st_addisoedge .. ok
 regress/st_addisonode .. ok
 regress/st_addedgemodface .. ok
 regress/st_addedgenewfaces .. ok
 regress/st_changeedgegeom .. ok
 regress/st_createtopogeo .. ok
 regress/st_getfacegeometry .. ok
 regress/st_getfaceedges .. ok
 regress/st_modedgeheal .. ok
 regress/st_modedgesplit .. ok
 regress/st_newedgeheal .. ok
 regress/st_newedgessplit .. ok
 regress/st_remedgenewface .. ok
 regress/st_remedgemodface .. ok
 regress/st_simplify .. failed (diff expected obtained: /projects/postgis/tmp/2.4_pg10w64/test_26_diff)
 regress/topoelement .. ok
 regress/topoelementarray_agg .. ok
 regress/topogeo_addlinestring .. ok
 regress/topogeo_addpoint .. ok
 regress/topogeo_addpolygon .. ok
 regress/topogeom_edit .. failed (diff expected obtained: /projects/postgis/tmp/2.4_pg10w64/test_32_diff)
 regress/topogeometry_type .. ok
 regress/topojson .. ok
 regress/topologysummary .. ok
 regress/topo2.5d .. ok
 regress/totopogeom .. failed (diff expected obtained: /projects/postgis/tmp/2.4_pg10w64/test_37_diff)
 regress/droptopology .. ok
 regress/droptopogeometrycolumn .. ok
 regress/copytopology .. failed (diff expected obtained: /projects/postgis/tmp/2.4_pg10w64/test_40_diff)
 regress/createtopogeom .. ok
 regress/createtopology .. ok
 regress/gml .. ok
 regress/getnodebypoint .. ok
 regress/getedgebypoint .. ok
 regress/getfacebypoint .. ok
 regress/getringedges .. ok
 regress/gettopogeomelements .. ok
 regress/layertrigger .. ok
 regress/validatetopology .. ok
 uninstall .. ok (4662)

Run tests: 51
Failed: 4

--- regress/st_simplify_expected	2016-04-27 10:57:37.693736400 -0400
+++ /projects/postgis/tmp/2.4_pg10w64/test_26_out	2017-05-26 02:22:17.991281200 -0400
@@ -1,9 +1,8 @@
 t
 L1
-N2
-S1|f|t
-S2|f|t
+ERROR:  Invalid geometry type (POLYGON) passed to TopoGeo_AddLinestring, expected LINESTRING
+N1
+S1|f|
+S2|f|
 L2
-HS1|f|t
-HS2|f|t
 f

--- regress/topogeom_edit_expected	2016-04-27 10:57:37.669735100 -0400
+++ /projects/postgis/tmp/2.4_pg10w64/test_32_out	2017-05-26 02:22:20.196285100 -0400
@@ -1,8 +1,5 @@
 create|t
 simple_line_layer|1
-1|start|1|10
-1|add|1|30
-1|rem|1|20
-1|dup|1|20
-1|mis|1|20
+ERROR:  Invalid geometry type (LINESTRING) passed to TopoGeo_AddPolygon, expected POLYGON
+ERROR:  Invalid geometry type (LINESTRING) passed to TopoGeo_AddPolygon, expected POLYGON
 Topology 'tt' dropped


--- regress/totopogeom_expected	2016-04-27 10:57:37.107702900 -0400
+++ /projects/postgis/tmp/2.4_pg10w64/test_37_out	2017-05-26 02:22:21.906287500 -0400
@@ -18,13 +18,13 @@
 ERROR:  Unsupported feature type TIN
 ERROR:  Unsupported feature type TRIANGLE
 ERROR:  Unsupported feature type CIRCULARSTRING
-POINT(0 0)|t
-LINESTRING(0 10,10 10)|t
-POLYGON((0 20,10 20,5 30,0 20),(2 22,8 22,5 28,2 22))|t
-MULTIPOINT(0 -10,5 -10)|t
-MULTILINESTRING((-1 10,-10 10),(-10 8,-2 9))|t
-MULTIPOLYGON(((100 20,110 20,105 30,100 20),(102 22,108 22,105 28,102 22)),((80 20,90 20,90 60,80 20)))|t
-GEOMETRYCOLLECTION(POINT(-100 -100),LINESTRING(-100 -90,-90 -90),POLYGON((-100 -80,-90 -80,-95 -70,-100 -80),(-98 -78,-92 -78,-95 -72,-98 -78)),MULTIPOINT(-100 -110,-95 -110),LINESTRING EMPTY,MULTILINESTRING((-101 -90,-110 -90),(-110 -92,-102 -91)),MULTIPOLYGON(((0 -80,10 -80,5 -70,0 -80),(2 -78,8 -78,5 -72,2 -78)),((-20 -80,-10 -80,-10 -40,-20 -80))))|GEOMETRYCOLLECTION(MULTIPOLYGON(((-100 -80,-95 -70,-90 -80,-100 -80),(-98 -78,-92 -78,-95 -72,-98 -78)),((0 -80,5 -70,10 -80,0 -80),(2 -78,8 -78,5 -72,2 -78)),((-20 -80,-10 -40,-10 -80,-20 -80))),MULTILINESTRING((-110 -92,-102 -91),(-101 -90,-110 -90),(-100 -90,-90 -90)),MULTIPOINT(-100 -110,-100 -100,-95 -110))
+ERROR:  Invalid geometry type (POINT) passed to TopoGeo_AddLinestring, expected LINESTRING
+ERROR:  Invalid geometry type (LINESTRING) passed to TopoGeo_AddPolygon, expected POLYGON
+ERROR:  Invalid geometry type (POLYGON) passed to TopoGeo_AddLinestring, expected LINESTRING
+ERROR:  Invalid geometry type (POINT) passed to TopoGeo_AddLinestring, expected LINESTRING
+ERROR:  Invalid geometry type (LINESTRING) passed to TopoGeo_AddPolygon, expected POLYGON
+ERROR:  Invalid geometry type (POLYGON) passed to TopoGeo_AddLinestring, expected LINESTRING
+ERROR:  Invalid geometry type (POINT) passed to TopoGeo_AddLinestring, expected LINESTRING
 MULTIPOINT EMPTY
 MULTIPOINT EMPTY
 MULTILINESTRING EMPTY
@@ -32,21 +32,19 @@
 MULTIPOLYGON EMPTY
 MULTIPOLYGON EMPTY
 GEOMETRYCOLLECTION EMPTY
-tolerance_1|0.5
-tolerance_topo_1|0.5
-tolerance_0|0
-custom_search_path|0
-#1790.1|0|0
-#1790.2|0|0
-#1790.3|0|0
-#1968.1|0
-#1968.2|0
-tgup1.1|5|100|1
-tgup1.2|5|200|2
-tgup1.3|5|200|4
+ERROR:  Invalid geometry type (POINT) passed to TopoGeo_AddLinestring, expected LINESTRING
+ERROR:  Invalid geometry type (POINT) passed to TopoGeo_AddLinestring, expected LINESTRING
+ERROR:  Invalid geometry type (POINT) passed to TopoGeo_AddLinestring, expected LINESTRING
+ERROR:  Invalid geometry type (POINT) passed to TopoGeo_AddLinestring, expected LINESTRING
+ERROR:  Invalid geometry type (POINT) passed to TopoGeo_AddLinestring, expected LINESTRING
+ERROR:  Invalid geometry type (LINESTRING) passed to TopoGeo_AddPolygon, expected POLYGON
+ERROR:  Invalid geometry type (POLYGON) passed to TopoGeo_AddLinestring, expected LINESTRING
+ERROR:  Invalid geometry type (LINESTRING) passed to TopoGeo_AddPolygon, expected POLYGON
+ERROR:  Invalid geometry type (LINESTRING) passed to TopoGeo_AddPolygon, expected POLYGON
+ERROR:  Invalid geometry type (POLYGON) passed to TopoGeo_AddLinestring, expected LINESTRING
 #3359.setval|1|2|1
-#3359.line.1|1
-#3359.line.2|2
-#3359.area.1|1
-#3359.area.2|2
+ERROR:  Invalid geometry type (LINESTRING) passed to TopoGeo_AddPolygon, expected POLYGON
+ERROR:  Invalid geometry type (LINESTRING) passed to TopoGeo_AddPolygon, expected POLYGON
+ERROR:  Invalid geometry type (POLYGON) passed to TopoGeo_AddLinestring, expected LINESTRING
+ERROR:  Invalid geometry type (POLYGON) passed to TopoGeo_AddLinestring, expected LINESTRING
 Topology 'tt' dropped


--- regress/copytopology_expected	2016-04-27 10:57:36.714680400 -0400
+++ /projects/postgis/tmp/2.4_pg10w64/test_40_out	2017-05-26 02:22:23.096289200 -0400
@@ -19,13 +19,13 @@
 1|CITY_data_UP_down|LAYER1|
 2|CITY_data_UP_down|LAYER2|
 3|CITY_data_UP_down|LAYER3|
-node_node_id_seq|22|1|1|9223372036854775807|1|1|0|f|t
-edge_data_edge_id_seq|26|1|1|9223372036854775807|1|1|0|f|t
-face_face_id_seq|9|1|1|9223372036854775807|1|1|0|f|t
-layer_id_seq|1|1|1|9223372036854775807|1|1|f|f
-topogeo_s_1|9|1|1|9223372036854775807|1|1|0|f|t
-topogeo_s_2|8|1|1|9223372036854775807|1|1|0|f|t
-topogeo_s_3|8|1|1|9223372036854775807|1|1|0|f|t
+22|0|t
+26|0|t
+9|0|t
+ERROR:  column "sequence_name" does not exist at character 8
+9|0|t
+8|0|t
+8|0|t
 Topology 'CITY_data_UP_down' dropped
 Topology 'city_data' dropped
 #2184.1|t