Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#351 closed defect (fixed)

Doc bug: Wrong return type for ST_Envelope()

Reported by: pracine Owned by: robe
Priority: medium Milestone: PostGIS 1.4.2
Component: postgis Version: 1.4.X
Keywords: Cc:

Description

Return type for St_Envelope() in the doc should be "geometry". It is now "boolean".

http://postgis.refractions.net/documentation/manual-1.4SVN/ST_Envelope.html

It is also not really clear in this page whether ST_Envelope() will return the bbox float4s version or the float8s version.

Change History (4)

comment:1 Changed 11 years ago by pracine

Milestone: PostGIS 1.4.1PostGIS 1.4.2

comment:2 Changed 11 years ago by robe

Resolution: fixed
Status: newclosed

Fixed at r5070 - r5073 (also added an example which hopefully clarifies the float4/float8 question) -- fixed for both trunk and branch/1.4

comment:3 Changed 11 years ago by mcayland

I've applied the correct fix to trunk for this (i.e. use full double precision calculation rather than using the BBOX cache to perform geometry calculations). I also fixed up ST_Expand() which was also doing a similar thing.

Regina - please can you verify and update the ST_Envelope() documentation accordingly? The whole section about float4 should simple be removed, along with the reference to float4 in the first paragraph.

Does anyone feel that this should be patched back to 1.4 branch?

comment:4 Changed 11 years ago by robe

I think its best not to patch back as that is kind of a borderline violation of behaving differently in a micro release. I don't think output behavior should change in a micro (if its not absolutely wrong and it was correctly documented)

Note: See TracTickets for help on using tickets.