Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#2088 closed defect (wontfix)

can we get rid of the xmllint check

Reported by: robe Owned by: strk
Priority: medium Milestone: PostGIS 2.1.0
Component: build/upgrade/install Version: master
Keywords: Cc:

Description

I just noticed when running that we have

A call like this:

xmllint --loaddtd --xinclude --valid postgis-out.xml > /dev/null

I know I think all winnie's (and mine) are with make check, not make or make install and I'm wondering if its this line.

Do we really need to validate the xml in make check? Can we get rid of it?

Change History (5)

comment:1 Changed 9 years ago by robe

Component: postgisbuild/upgrade/install
Owner: changed from pramsey to strk

comment:2 Changed 9 years ago by strk

I think "make check" should check everything built by "make" If docs are not built by "make" then we can move the check to an appropriately named rule (like "make docs-check" ?)

comment:3 Changed 9 years ago by robe

I think we should move it. The only reason xml needs to be used for regular checking is to generate the comments and then I would say we don't care about xmllint just care if the comments are installable or not.

We don't use make check for building docs.

comment:4 Changed 9 years ago by robe

Milestone: PostGIS 2.1.0PostGIS Future
Resolution: wontfix
Status: newclosed

this seems bearable. I'm not even sure it happens anymore or maybe it doesn't for me now that I set before I make

XSLTPROCFLAGS=

comment:5 Changed 9 years ago by robe

Milestone: PostGIS FuturePostGIS 2.1.0
Note: See TracTickets for help on using tickets.