Opened 2 years ago
Last modified 6 months ago
#2384 reopened task
Update Leaflet demo to point to FOSS4G location
Reported by: | kalxas | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | OSGeoLive17.0 |
Component: | OSGeoLive | Keywords: | leaflet |
Cc: | osgeolive@… |
Description
Attachments (2)
Change History (18)
comment:1 by , 2 years ago
by , 2 years ago
Attachment: | leaflet-demo-location.png added |
---|
by , 2 years ago
Attachment: | leaflet-demo-version.png added |
---|
follow-up: 3 comment:2 by , 2 years ago
We should be at https://packages.ubuntu.com/jammy/libjs-leaflet 1.7.1.
comment:3 by , 2 years ago
Replying to kalxas:
We should be at https://packages.ubuntu.com/jammy/libjs-leaflet 1.7.1.
Thanks, I missed that bin/install_leaflet.sh
uses above package...
I will check the cause why L.version
returns "1.6.0".
comment:4 by , 2 years ago
I checked installed leaflet.js,
$ dpkg -L libjs-leaflt : $ vi /usr/share/javascript/leaflet/leaflet.js
and confirmed that the header and variable versions are "1.6.0",
/* @preserve * Leaflet 1.6.0, ... : var version = "1.6.0";
but I also confirmed that "1.7.0" API changes are included in the same file, https://github.com/Leaflet/Leaflet/releases/tag/v1.7.1
API changes
so, "1.7.1" (or "1.7.0") seems to be installed correctly except L.version
.
follow-up: 7 comment:5 by , 2 years ago
yet beta2 shows
/usr/share/javascript/leaflet/leaflet.js /* @preserve * Leaflet 1.6.0, a JS library for interactive maps. http://leafletjs.com * (c) 2010-2019 Vladimir Agafonkin, (c) 2010-2011 CloudMade */ (function (global, factory) { typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) : typeof define === 'function' && define.amd ? define(['exports'], factory) : (global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global.L = {})); })(this, (function (exports) { 'use strict'; var version = "1.6.0"; /* * @namespace Util *
comment:7 by , 2 years ago
Replying to comment:5, comment:6:
yet beta2 shows :
Yes, but actual code seems to be "1.7.1" (or "1.7.0"), so this will not be problem.
QGIS and geonode both have internal copies of leaflet
Okay, thanks for the information.
---
I can't join today's meeting from Japan, because it's midnight (28:00 JST), but if there are no further problems, then I will try the followings at tomorrow.
To change the location, quick start document side fix seems to be also necessary.
(I guess that just shifting the coordinates from Bucharest to "Firenze Fiera Congress & Exhibition Center" will be enough.)
:
I can try above (both code and doc) at this weekend (probably Sunday), if it's no problem.
comment:8 by , 2 years ago
a simple test $ curl http://localhost/leaflet/leaflet.js
returns
... v1.6 with some patches
follow-up: 10 comment:9 by , 2 years ago
short meeting today -- leaflet.js
is installed more than once on this disk; we would like to avoid duplication and use similar versions when possible; a fresh package for python3-ipyleaflet
might be the next step; a new leaflet.js
will be at the same local URL
comment:11 by , 2 years ago
I fixed the location on the following PRs.
- https://github.com/OSGeo/OSGeoLive/pull/345 (Thanks for merging)
- https://github.com/OSGeo/OSGeoLive-doc/pull/776
---
By the way, during checking leaflet quickstart document, the following changes seem to be necessary, but those can be done on another ticket.
Geospatial/Spatial Tools/Start Mapnik & TileStache
menu doesn't exist. (#2352 may be related with this.)- https://github.com/OSGeo/OSGeoLive-doc/blob/master/doc/quickstart/leaflet_quickstart.rst#running
Prior to running this quick start you should start TileStache. On OSGeoLive this can be found under Geospatial\Spatial Tools\Start Mapnik & TileStache. This will provide background tiles that will be used in this demo.
- https://github.com/OSGeo/OSGeoLive-doc/blob/master/doc/quickstart/leaflet_quickstart.rst#running
- IE 8 stylesheet reading comment should be deleted from both code and doc, because there is no
/leaflet/leaflet.ie.css
.- https://github.com/OSGeo/OSGeoLive-doc/blob/master/doc/quickstart/leaflet_quickstart.rst#preparing-your-page
<!--[if lte IE 8]> <link rel="stylesheet" href="/leaflet/leaflet.ie.css" /> <![endif]-->
- https://github.com/OSGeo/OSGeoLive-doc/blob/master/doc/quickstart/leaflet_quickstart.rst#preparing-your-page
follow-up: 14 comment:12 by , 2 years ago
The Leaflet quickstart needs an update, mapstache is not available anymore in the disk.
comment:13 by , 2 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Leaflet demo points at Firenze on build157
comment:14 by , 2 years ago
Replying to comment:12:
The Leaflet quickstart needs an update, mapstache is not available anymore in the disk.
Okay, thanks for confirmation.
I will create a new issue for that.
Replying to comment:13:
Leaflet demo points at Firenze on build157
Okay, thanks!
comment:15 by , 18 months ago
Keywords: | leaflet added |
---|---|
Milestone: | OSGeoLive15.0 → OSGeoLive16.0 |
Priority: | critical → major |
Resolution: | fixed |
Status: | closed → reopened |
Summary: | Update Leaflet demo to point to Firenze → Update Leaflet demo to point to FOSS4G location |
The leaflet demo should now point to Prizren
comment:16 by , 6 months ago
Milestone: | OSGeoLive16.0 → OSGeoLive17.0 |
---|
Ticket retargeted after milestone closed
I also confirmed that current beta1 vmdk version points FOSS4G 2019 Bucharest location. :)
To change the location, quick start document side fix seems to be also necessary.
(I guess that just shifting the coordinates from Bucharest to "Firenze Fiera Congress & Exhibition Center" will be enough.)
Also, I confirmed that Leaflet version is still "1.6.0" by executing
L.version
on Firefox Web Developer Tools - Console tab, and I felt that upgrading the version to the latest "1.8.0" will be better.I can try above (both code and doc) at this weekend (probably Sunday), if it's no problem.