Opened 21 years ago

Last modified 13 years ago

#472 assigned defect

Clean up mapservObj member names...

Reported by: sdlime Owned by: sdlime
Priority: low Milestone: FUTURE
Component: MapServer CGI Version:
Severity: minor Keywords:
Cc:

Description (last modified by sdlime)

They are named unlike anything else in the code. There are a few vars in there
that have very cryptic names (e.g. LRN). This would involve some changes to
mapserv.c, mapserv_fcgi.c and maptemplate.c. I don't know how prevelant this
object is in the scripting envs.

Attachments (1)

codingstyle.txt (3.3 KB ) - added by dmorissette 20 years ago.
DMSG Coding Style

Download all attachments as: .zip

Change History (10)

comment:1 by dmorissette, 20 years ago

Cc: warmerdam@… sgillies@… mapserver-bugs@… added
Milestone: 4.4 release
mapservObj comes from our end, and the source of the problem is a collision
between our coding style and yours. Let's work on this together during the 4.3
release cycle to cleanup the mapservObj. 

Perhaps at the same time we could come up with a documented coding style that
mapserver developers should follow... it doesn't have to be long, just a few
guidelines on naming variables, files, indenting of code, etc.

comment:2 by sgillies@…, 20 years ago

How about we use the wiki to document the minimum number of rules?
We could start here:

http://mapserver.gis.umn.edu/cgi-bin/wiki.pl?MapServerCodingStandards

I began with some style notes that impact the MapScript API, my 
particular area of interest.  I can adapt to whatever is decided for
C style in general.  I'm agnostic about braces, and like 4-space 
indentation.  No tabs.

by dmorissette, 20 years ago

Attachment: codingstyle.txt added

DMSG Coding Style

comment:3 by sdlime, 17 years ago

Description: modified (diff)
Milestone: 5.0 release5.2 release
Version: 4.1

Since this is really just housekeeping it tends to slip. Here it goes again... to 5.2.

Steve

comment:4 by sdlime, 16 years ago

I'm actually doing this as part of RFC 36 implementation.

Steve

comment:5 by sdlime, 16 years ago

Cc: sgillies@… removed
Status: newassigned

comment:6 by sdlime, 16 years ago

Milestone: 5.2 release5.4 release

I'll finish this in 5.4...

Steve

comment:7 by dmorissette, 14 years ago

Milestone: 5.6 release6.0 release

comment:8 by sdlime, 13 years ago

Milestone: 6.0 releaseFUTURE

comment:9 by sdlime, 13 years ago

Priority: highlow
Note: See TracTickets for help on using tickets.