#2613 closed defect (fixed)
PostGIS connection not always sanitized after failed query
| Reported by: | dfuhry | Owned by: | pramsey |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | PostGIS Interface | Version: | svn-trunk (development) |
| Severity: | major | Keywords: | mappostgis.c msPOSTGISSanitizeConnection |
| Cc: | pramsey, havard.tveite@… |
Description
Followup from bug #2497. In mappostgis.c, whenever PQexec gets called, if the query has failed, we need to call msPOSTGISSanitizeConnection(layerinfo->conn).
It seems this needs to be done in four additional places:
line 700: msPOSTGISLayerClose()
line 1430: msPOSTGISLayerGetItems()
line 1601: msPOSTGISLayerRetrievePGVersion()
line 1749: msPOSTGISLayerRetrievePK()
Patch attached.
Attachments (1)
Change History (4)
by , 16 years ago
| Attachment: | ms_sanitize_more.v1.patch added |
|---|
comment:1 by , 16 years ago
| Cc: | added |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
comment:2 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:3 by , 16 years ago
The patch helped with my failure case (mapserver "crash" due to some single quote problems). After applying the patch, no crash occurred, and, for some reason, the problem query succeeded in getting the points from PostGIS.
Note:
See TracTickets
for help on using tickets.
Havard, can you try this patch with your failure case?