Opened 16 years ago
Closed 16 years ago
#2600 closed defect (fixed)
entity_encoded_follow_text test broken in 5.0 and trunk
| Reported by: | pramsey | Owned by: | sdlime |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.2 release |
| Component: | MapServer C Library | Version: | unspecified |
| Severity: | normal | Keywords: | |
| Cc: | tbonfort |
Description
The result image (as generated by 5.0) appears to be wrong, in that the entities are not encoded in the second example. The result from trunk appears to be wrong, in that two of the cases in the second example don't work at all.
Attachments (2)
Change History (6)
by , 16 years ago
| Attachment: | trunk_entity_encoded_follow_text.png added |
|---|
comment:1 by , 16 years ago
| Owner: | changed from to |
|---|
comment:2 by , 16 years ago
| Cc: | added |
|---|---|
| Owner: | changed from to |
Steve, from my testing, this regression was introduced in r7231
the "follow" labels reappear if the label->buffer is set to a smaller value. it seems like the label's polygon is incorrectly calculated, as the labels are discarded at http://trac.osgeo.org/mapserver/browser/trunk/mapserver/maplabel.c#L253
you'll find the test data in msautotest misc/agg_entity_encoded_follow_text.map
comment:3 by , 16 years ago
| Milestone: | → 5.2 release |
|---|
comment:4 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
The problem was that when the code was reshuffled the label->force check was omitted and in the test case that caused path following labels not to be drawn. The buffer checks are correct if you remove the FORCE TRUE line. Fixed in r7749.
Steve
Trunk result