Opened 19 years ago

Last modified 17 years ago

#1088 closed defect

GetMap Width/Height/Format are required parameters — at Version 9

Reported by: assefa Owned by: tomkralidis
Priority: high Milestone: 5.0 release
Component: WMS Server Version: 4.4
Severity: normal Keywords:
Cc: nsavard@…, bartvde@…, tomkralidis, sdlime, jmckenna@…

Description (last modified by dmorissette)

There is no exception returned when the GetMap request is sent without the 
width, height or format.

Change History (9)

comment:1 by assefa, 19 years ago

Cc: nsavard@… added
Norm,

Are there any validations done on required parameters in the wms compliance test
suite ? I have briefly checked and could not find one.

Required parameters that are not tested here are WIDTH, HEIGHT, SRS, BBOX,
Format, STYLES (required if there is no SLD).

It is weird that no one realized this. Sending exception when these parameters
are missing will probably cause some problems for some.

comment:2 by bartvde@…, 19 years ago

Cc: bartvde@… added
AFAIK there are no test cases for this in the OGC CITE tests, which is quite weird.

comment:3 by dmorissette, 19 years ago

Milestone: 4.6 release
Since that's not part of CITE (otherwise we would not pass the tests), and this
doesn't prevent the software from working (it works with defaults), then I say
we push this to 4.6. No need to take chances to break 4.4 for such a minor detail.

comment:4 by nsavard@…, 19 years ago

I checked the WMS OGC CITE tests and effectively, as Bart said, there is no test
for that part of the specification.

comment:5 by jdoyon@…, 18 years ago

Just a "bump" :)

I'm on 4.6.1 and this is still the case ...

Apparently the behavior changed in how projection is handled though.  Specifying
an SRS without a BBOX doesn't work the same now as it did in 3.6.6? (In 3.6.6 I
guess the default extent was reprojected, so the expected map was returned
anyways.  Now an SRS without a BBOX just returns a blank map, presumably because
the extent isn't reprojected?)

I know, it's the client's fault for not making sure they use all mandatory
parameters, but still, an error really should be raised!

J.F.

comment:6 by tomkralidis, 17 years ago

Cc: tomkralidis added

Any update on this one? The spec says they're required. CITE tests ignore them. Checking for them (and throwing exception) might cause problems for existing clients.

What do all think? My vote would be to check for the required parameters and throw exception if they are not present.

comment:7 by bartvde, 17 years ago

I agree with you Tom. Makes sense, and if this breaks something, people should fix their client anyway since if they change WMS vendor, they will have problems as well.

comment:8 by tomkralidis, 17 years ago

Cc: sdlime added

Any other comments here? Not sure how we should proceed with a decision here (Daniel/Assefa?). If we do decide to check as per above, I can take this one.

comment:9 by dmorissette, 17 years ago

Description: modified (diff)
Owner: changed from mapserverbugs to tomkralidis

I wasn hesitant but Bart convinced me with his last comment, so I'd say go ahead Tom unlees Assefa has objections. (And don't forget to update HISTORY.TXT and MIGRATION_GUIDE.TXT since this is a fix/change that may have impact on some users).

Note: See TracTickets for help on using tickets.