Changes between Version 85 and Version 86 of GSoC/2021/SingleWindowLayout


Ignore:
Timestamp:
Aug 18, 2021, 6:03:03 AM (3 years ago)
Author:
lindakladivova
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • GSoC/2021/SingleWindowLayout

    v85 v86  
    138138{{{#!td
    139139'''wxGUI refactoring:'''
    140  - Build all other Map Frames based wx.!Statusbar (see PR https://github.com/OSGeo/grass/pull/1689)
     140 - Build all other Map Frames based wx.!StatusBar (see PR https://github.com/OSGeo/grass/pull/1689)
    141141 - Utilize Map Display panel into Map Display frame (see PR https://github.com/OSGeo/grass/pull/1675)
    142142}}}
     
    157157{{{#!td
    158158'''wxGUI refactoring:'''
    159  - Build all other Map Frames based !wx.Statusbar (see PR https://github.com/OSGeo/grass/pull/1689)
     159 - Build all other Map Frames based wx.!StatusBar (see PR https://github.com/OSGeo/grass/pull/1689)
    160160 - Utilize Map Display panel into Map Display frame (see PR https://github.com/OSGeo/grass/pull/1675)
    161161}}}
     
    176176{{{#!td
    177177'''wxGUI refactoring:'''
    178  - Build all other Map Frames based !wx.Statusbar (see PR https://github.com/OSGeo/grass/pull/1689)
     178 - Build all other Map Frames based wx.!StatusBar (see PR https://github.com/OSGeo/grass/pull/1689)
    179179 - Utilize Map Display panel into Map Display frame (see PR https://github.com/OSGeo/grass/pull/1675)
    180180
     
    209209{{{#!td
    210210'''wxGUI refactoring:'''
    211  - Build all other Map Frames based !wx.Statusbar (see https://github.com/OSGeo/grass/pull/1689)
     211 - Build all other Map Frames based wx.!StatusBar (see https://github.com/OSGeo/grass/pull/1689)
    212212 - Utilize Map Display panel into Map Display frame (see https://github.com/OSGeo/grass/pull/1675)
    213213
     
    234234{{{#!td
    235235'''wxGUI refactoring:'''
    236  - Build all other Map Frames based !wx.Statusbar (see https://github.com/OSGeo/grass/pull/1689)
     236 - Build all other Map Frames based wx.!StatusBar (see https://github.com/OSGeo/grass/pull/1689)
    237237 - Utilize Map Display panel into Map Display frame (see https://github.com/OSGeo/grass/pull/1675)
    238238
     
    400400Similarly as the last week, I focused on the GUI refactoring. I worked on the main refactoring PR (see ​https://github.com/OSGeo/grass/pull/1675). In terms of the main Map Display I am done here. However, me and my mentors realized that changes influence also other Map Frames - particularly g.gui.rdigit, d.mon, Map Swipe, Ground Control Point and IClass frame.
    401401
    402 There were two possible ways how to proceed. First, I started with the statusbars for all the frames that we need newly to be created based on wx.Statubar widget (see https://github.com/OSGeo/grass/pull/1689). Then we came up with another concept, namely delegating methods using metaprogramming. Although this path seemed cheap at first (we talked about it very intensively on videocall on Wednesday), after a few hours of studying, we came to the conclusion that it is inappropriate in our case. And this decision subsequently opened PR https://github.com/OSGeo/grass/pull/1689 again.
     402There were two possible ways how to proceed. First, I started with the statusbars for all the frames that we need newly to be created based on wx.!StatusBar widget (see https://github.com/OSGeo/grass/pull/1689). Then we came up with another concept, namely delegating methods using metaprogramming. Although this path seemed cheap at first (we talked about it very intensively on videocall on Wednesday), after a few hours of studying, we came to the conclusion that it is inappropriate in our case. And this decision subsequently opened PR https://github.com/OSGeo/grass/pull/1689 again.
    403403
    404404Meantime, I also discovered the bug related to hiding statusbar and toolbars. Hiding does not work properly for above-mentioned map frames as e.g. Map Swipe. I set up the issue https://github.com/OSGeo/grass/issues/1691.