314 | | As the last week, I focused on the GUI refactoring. I worked on the main refactoring PR (see https://github.com/OSGeo/grass/pull/1675), in terms of the main Map Display I am done here. However, we realized that changes influence also other Map Frames based - particularly g.gui.rdigit, d.mon, Map Swipe, Ground Control Point and IClass frame. |
315 | | |
316 | | There were two ways to proceed. First, I started with the statusbars for all the frames that we need newly to be created based on wx.Statubar widget (see https://github.com/OSGeo/grass/pull/1689). Then we came up with another concept, namely delegating methods using metaprogramming. Although this path seemed cheap at first (we talked about it very intensively on videocall on Wednesday), after a few hours of studying, we came to the conclusion that it is inappropriate in our case. So that, I will again start to work on (see https://github.com/OSGeo/grass/pull/1689). |
317 | | |
318 | | Meantime, I also discovered the bug when hiding statusbar and toolbars does not work properly for map frames as e.g. Map Swipe (and other standlalone map frames) and I set up the issue for it (see https://github.com/OSGeo/grass/issues/1691). |
| 315 | As the last week, I focused on the GUI refactoring. I worked on the main refactoring PR (see https://github.com/OSGeo/grass/pull/1675). In terms of the main Map Display I am done here. However, me and mentors realized that changes influence also other Map Frames - particularly g.gui.rdigit, d.mon, Map Swipe, Ground Control Point and IClass frame. |
| 316 | |
| 317 | There were two ways to proceed. First, I started with the statusbars for all the frames that we need newly to be created based on wx.Statubar widget (see https://github.com/OSGeo/grass/pull/1689). Then we came up with another concept, namely delegating methods using metaprogramming. Although this path seemed cheap at first (we talked about it very intensively on videocall on Wednesday), after a few hours of studying, we came to the conclusion that it is inappropriate in our case. And this decision again opened PR https://github.com/OSGeo/grass/pull/1689. |
| 318 | |
| 319 | Meantime, I also discovered the bug related to hiding statusbar and toolbars that does not work properly for above-mentioned map frames as e.g. Map Swipe. I set up the issue for it (see https://github.com/OSGeo/grass/issues/1691). |