Opened 10 years ago

Closed 9 years ago

#993 closed defect (fixed)

gem fails to compile on ubuntu 9.1

Reported by: mlechner Owned by: grass-dev@…
Priority: normal Milestone: 6.4.0
Component: Compiling Version: svn-trunk
Keywords: gem Cc:
CPU: Unspecified Platform: Linux

Description

gem fails to compile (ubuntu 9.1):

user@comp:/svn/grass/trunk/gem$ make
gcc  -g -O2   -I/svn/grass/trunk/dist.i686-pc-linux-gnu/include -I/svn/grass/trunk/dist.i686-pc-linux-gnu/include  -D_FILE_OFFSET_BITS=64  -DPACKAGE=\"\"   -I/svn/grass/trunk/dist.i686-pc-linux-gnu/include -I/svn/grass/trunk/dist.i686-pc-linux-gnu/include -o OBJ.i686-pc-linux-gnu/actions.o -c actions.c
actions.c: In function ‘check_extension’:
actions.c:51: warning: ignoring return value of ‘fscanf’, declared with attribute warn_unused_result
actions.c:79: warning: ignoring return value of ‘chdir’, declared with attribute warn_unused_result
actions.c: In function ‘unpack_extension’:
actions.c:99: warning: ignoring return value of ‘mkstemp’, declared with attribute warn_unused_result
actions.c: In function ‘query_extension’:
actions.c:233: warning: ignoring return value of ‘system’, declared with attribute warn_unused_result
actions.c: In function ‘source_clean’:
actions.c:943: warning: ignoring return value of ‘system’, declared with attribute warn_unused_result
actions.c: In function ‘run_post’:
actions.c:1095: warning: ignoring return value of ‘getcwd’, declared with attribute warn_unused_result
In file included from /usr/include/fcntl.h:217,
                 from actions.c:26:
In function ‘open’,
    inlined from ‘unpack_extension’ at actions.c:100:
/usr/include/bits/fcntl2.h:51: error: call to ‘__open_missing_mode’ declared with attribute error: open with O_CREAT in second argument needs 3 arguments
make: *** [OBJ.i686-pc-linux-gnu/actions.o] Fehler 1

Change History (9)

comment:1 Changed 10 years ago by mlechner

Version: unspecifiedsvn-trunk

comment:2 Changed 10 years ago by martinl

BTW, couldn't be gem replaced by improved g.extension in trunk? Martin

comment:3 Changed 10 years ago by martinl

Component: defaultCompiling
Keywords: compile removed

comment:4 in reply to:  2 ; Changed 10 years ago by neteler

Milestone: 7.0.06.4.0

Replying to martinl:

BTW, couldn't be gem replaced by improved g.extension in trunk? Martin

Yes, please (also) substitute g.extension shell script in 6.4 with g.extension Python script from trunk. The shell script approach isn't really working, so it is essentially a bugfix. A semi-broken g.extension in 6.4 does not help anyone.

Additionally, it is way easier to use than GEM.

Markus

comment:5 in reply to:  4 Changed 10 years ago by mlennert

Replying to neteler:

Replying to martinl:

BTW, couldn't be gem replaced by improved g.extension in trunk? Martin

Yes, please (also) substitute g.extension shell script in 6.4 with g.extension Python script from trunk. The shell script approach isn't really working, so it is essentially a bugfix. A semi-broken g.extension in 6.4 does not help anyone.

Additionally, it is way easier to use than GEM.

In principle I agree, except for #620. This still needs to be solved.

Moritz

comment:6 in reply to:  description ; Changed 10 years ago by glynn

Replying to mlechner:

gem fails to compile (ubuntu 9.1):

In file included from /usr/include/fcntl.h:217,
                 from actions.c:26:
In function ‘open’,
    inlined from ‘unpack_extension’ at actions.c:100:
/usr/include/bits/fcntl2.h:51: error: call to ‘__open_missing_mode’ declared with attribute error: open with O_CREAT in second argument needs 3 arguments

Fixed in trunk with r41376.

comment:7 Changed 10 years ago by neteler

How about:

--- actions.c   (revision 41284)
+++ actions.c   (working copy)
@@ -97,7 +97,7 @@
     /* TODO: Do not hardcode temp paths */
     strcpy(TMPDIR, "/tmp/grass.extension.XXXXXX");     /* tmpdir is a global variable */
     mkstemp(TMPDIR);
-    fd = open(TMPDIR, O_CREAT);
+    fd = open(TMPDIR, O_CREAT, 0777);
     if (fd == -1) {
        print_error(ERR_UNPACK_EXT,
                    "could not create temp directory name: %s",

?

comment:8 in reply to:  6 Changed 10 years ago by mlechner

I still get the same error after svn up - revision 41377

Fixed in trunk with r41376.

comment:9 Changed 9 years ago by hamish

Resolution: fixed
Status: newclosed

please reopen if this still stops GRASS from building cleanly.

Note: See TracTickets for help on using tickets.