Opened 10 years ago

Closed 4 years ago

#770 closed enhancement (fixed)

Close wxGUI on GRASS CLI exit

Reported by: marisn Owned by: martinl
Priority: minor Milestone: 7.0.4
Component: wxGUI Version: 6.4.0 RCs
Keywords: init Cc: grass-dev@…
CPU: Unspecified Platform: Linux

Description

When user exits from GRASS CLI (terminal), Init.sh should issue a close command to any remaining wxGUI processes.

See r39350 for ideas how it's done in gis.m.

Reported by Martin: http://lists.osgeo.org/pipermail/grass-dev/2009-September/046460.html

Change History (17)

comment:1 Changed 10 years ago by martinl

Cc: martinl added

comment:2 Changed 10 years ago by cmbarton

This needs to be done in init.sh I believe.

Michael

comment:3 Changed 7 years ago by neteler

Milestone: 6.4.06.4.4

Still to be done (both G6 and G7).

comment:4 Changed 5 years ago by mlennert

Type: defectenhancement

I wouldn't consider this a bug. Reclassifying as enhancement wish.

comment:5 Changed 4 years ago by wenzeslaus

Please see and try trunk after r66917, r66918, r66920, and r66982 by martinl.

comment:6 in reply to:  5 ; Changed 4 years ago by martinl

Replying to wenzeslaus:

Please see and try trunk after r66917, r66918, r66920, and r66982 by martinl.

right, I didn't announce yet. I was able to test on Windows 7 (cmd), Debian unstable (bash). Any testing is highly welcome! I would like to backport it to relbr70 before 7.0.3RC1 (January 2016).

I also changed WinGRASS (currently only trunk, standalone installator) to start cmd minimized. I am not sure if it's good idea, it take some time when startup screen appears and user could have feeling that nothing happend (cmd is started minimized) and start GRASS several times. Starting cmd in normal mode is probably better idea in the sense that user has some information that GRASS is starting. On the other side minimized cmd is not so scary for most of Windows users ;-) What do you think?

comment:7 in reply to:  5 ; Changed 4 years ago by martinl

Replying to wenzeslaus:

Please see and try trunk after r66917, r66918, r66920, and r66982 by martinl.

BTW, these commits enable to close CLI terminal (cmd) automatically when quiting GUI. The ticket reports other issue. To close GUI automaticaly (currently GUI just hangs and become unfunctional) when closing CLI terminal.

comment:8 Changed 4 years ago by martinl

Milestone: 6.4.47.0.3

comment:9 in reply to:  6 Changed 4 years ago by hellik

Replying to martinl:

Starting cmd in normal mode is probably better idea in the sense that user has some information that GRASS is starting. On the other side minimized cmd is not so scary for most of Windows users ;-) What do you think?

Launching <wxpython> GUI in the background, please wait...

this line is the important information already in cmd. I may prefer the the normal mode. windows users should be scared of windows, not of grass ... ;-)

comment:10 in reply to:  6 ; Changed 4 years ago by mlennert

Replying to martinl:

Replying to wenzeslaus:

Please see and try trunk after r66917, r66918, r66920, and r66982 by martinl.

right, I didn't announce yet. I was able to test on Windows 7 (cmd), Debian unstable (bash). Any testing is highly welcome! I would like to backport it to relbr70 before 7.0.3RC1 (January 2016).

I also changed WinGRASS (currently only trunk, standalone installator) to start cmd minimized. I am not sure if it's good idea, it take some time when startup screen appears and user could have feeling that nothing happend (cmd is started minimized) and start GRASS several times. Starting cmd in normal mode is probably better idea in the sense that user has some information that GRASS is starting. On the other side minimized cmd is not so scary for most of Windows users ;-) What do you think?

-1 (to minimizing cmd)

I find it useful to have cmd visible, including for teaching.

Moritz

comment:11 in reply to:  10 Changed 4 years ago by martinl

Replying to mlennert:

I also changed WinGRASS (currently only trunk, standalone installator) to start cmd minimized. I am not sure if it's good idea, it take some time when startup screen appears and user could have feeling that nothing happend (cmd is started minimized) and start GRASS several times. Starting cmd in normal mode is probably better idea in the sense that user has some information that GRASS is starting. On the other side minimized cmd is not so scary for most of Windows users ;-) What do you think?

-1 (to minimizing cmd)

I find it useful to have cmd visible, including for teaching.

OK, reverted in r67119

comment:12 in reply to:  7 ; Changed 4 years ago by wenzeslaus

Replying to martinl:

Replying to wenzeslaus:

Please see and try trunk after r66917, r66918, r66920, and r66982 by martinl.

BTW, these commits enable to close CLI terminal (cmd) automatically when quiting GUI. The ticket reports other issue. To close GUI automaticaly (currently GUI just hangs and become unfunctional) when closing CLI terminal.

The GUIs left behind after closing GRASS GIS now seem to be a bigger problem. On thing is that from user perspective the command line and GUI are now more connected. (Fortunately, after r66920, there is no more the danger of terminating a different process.) BTW, I like it much more after r67244.

comment:13 in reply to:  12 ; Changed 4 years ago by martinl

Replying to wenzeslaus:

The GUIs left behind after closing GRASS GIS now seem to be a bigger problem. On thing is that from user perspective the command line and GUI are now more connected. (Fortunately, after

attempt to solve this issue applied in r67306

comment:14 Changed 4 years ago by martinl

Milestone: 7.0.37.0.4

comment:15 in reply to:  13 Changed 4 years ago by martinl

Replying to martinl:

attempt to solve this issue applied in r67306

backported to relbr70 in r67731. Please test.

comment:16 Changed 4 years ago by martinl

Cc: grass-dev@… added; martinl removed
Owner: changed from grass-dev@… to martinl
Status: newassigned

comment:17 Changed 4 years ago by martinl

Resolution: fixed
Status: assignedclosed

Tested closing. Feel free to reopen if needed.

Note: See TracTickets for help on using tickets.