Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#3797 closed defect (fixed)

r.horizon suffix gets messed up in multi-direction mode

Reported by: sbl Owned by: grass-dev@…
Priority: normal Milestone: 7.8.0
Component: Raster Version: svn-trunk
Keywords: r.horizon Cc:
CPU: Unspecified Platform: Linux

Change History (5)

comment:1 Changed 6 months ago by mmetz

Fixed in trunk r74298.

comment:3 in reply to:  2 Changed 6 months ago by mmetz

comment:4 Changed 6 months ago by sbl

Resolution: fixed
Status: newclosed

Very good. Then I take the liberty to close this ticket...

comment:5 in reply to:  4 Changed 6 months ago by mmetz

Replying to sbl:

Very good. Then I take the liberty to close this ticket...

Hi Stefan, you are the original reporter of this ticket, therefore you have IMHO the right to close the ticket. Someone else submitting a fix can also close the ticket if this person is really confident that the issue has been fixed.

In this case, my system behaved differently: the wrong output on http://fatra.cnr.ncsu.edu/grassgistests/ was "test_horizon_output_from_elevation_%03", but on my system it was "test_horizon_output_from_elevation_", i.e. my system behaved differently. With my fix, my system produced correct output, and I was quite but not really sure that my fix works on other systems as well. Thus waiting for confirmation by the original reporter that the fix is working on other systems as well.

This particular bug and the related fix passed CI, thus CI is in this case not good enough, only the test for r.horizon. Another point to

  1. get the testsuite all green
  2. make CI run the testsuite and let CI fail if the testsuite is not all green
Note: See TracTickets for help on using tickets.