#3797 closed defect (fixed)
r.horizon suffix gets messed up in multi-direction mode
| Reported by: | sbl | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.8.0 |
| Component: | Raster | Version: | svn-trunk |
| Keywords: | r.horizon | Cc: | |
| CPU: | Unspecified | Platform: | Linux |
Description
Suffixes for angles in r.horizon get messed up and become "%03". See:
Change History (5)
comment:1 by , 6 years ago
follow-up: 3 comment:2 by , 6 years ago
Tested successfully : http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2019-03-23-07-00/report_for_nc_spm_full_v2alpha_nc/raster/r.horizon/test_r_horizon/index.html
Backport candidate?
comment:3 by , 6 years ago
Replying to sbl:
Tested successfully : http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2019-03-23-07-00/report_for_nc_spm_full_v2alpha_nc/raster/r.horizon/test_r_horizon/index.html
Backport candidate?
No because only trunk was affected.
follow-up: 5 comment:4 by , 6 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Very good. Then I take the liberty to close this ticket...
comment:5 by , 6 years ago
Replying to sbl:
Very good. Then I take the liberty to close this ticket...
Hi Stefan, you are the original reporter of this ticket, therefore you have IMHO the right to close the ticket. Someone else submitting a fix can also close the ticket if this person is really confident that the issue has been fixed.
In this case, my system behaved differently: the wrong output on http://fatra.cnr.ncsu.edu/grassgistests/ was "test_horizon_output_from_elevation_%03", but on my system it was "test_horizon_output_from_elevation_", i.e. my system behaved differently. With my fix, my system produced correct output, and I was quite but not really sure that my fix works on other systems as well. Thus waiting for confirmation by the original reporter that the fix is working on other systems as well.
This particular bug and the related fix passed CI, thus CI is in this case not good enough, only the test for r.horizon. Another point to
- get the testsuite all green
- make CI run the testsuite and let CI fail if the testsuite is not all green
Fixed in trunk r74298.