Opened 6 years ago
Closed 6 years ago
#3499 closed enhancement (wontfix)
Backport of new ZSTD compression
| Reported by: | neteler | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.4.2 |
| Component: | LibRaster | Version: | unspecified |
| Keywords: | ZSTD compression | Cc: | |
| CPU: | All | Platform: | All |
Description (last modified by )
Carried over from #2750
Replying to comment:69 neteler:
Concerning ZSTD compression: backport candidate for 7.4.1.
... for this I identified
- r71892 update documentation for GRASS compression methods
- r71891 libraster: update for ZSTD, use new G_compress_bound()
- r71890 libgis: add ZSTD (Zstandard) compression
- r71889 add ZSTD (Zstandard) compression to the Make system
Probably also helpful:
- r72030 libraster: more informative messages when reading a row fails
- r72031 libgis: more informative messages when (de)compression fails
- r72042 libgis: add warnings when writing compressed data fails
Is anything missing from this list?
Change History (7)
follow-up: 3 comment:1 by , 6 years ago
comment:3 by , 6 years ago
Replying to mmetz:
Replying to neteler:
Carried over from #2750
Replying to comment:69 neteler:
Concerning ZSTD compression: backport candidate for 7.4.1.
IMHO ZSTD compression is not a backport candidate because it is a new feature. Moreover, substantial changes were introduced to both the gis and raster library, which are in no way a bugfix, disqualifying it for backporting.
Emphasizing the backporting issue: backporting (in this case) is not trivial because it involves several low-level changes. If you want to use ZSTD compression, use trunk r71892. If you want more meaningful messages about why (de-)compression fails, use trunk r72042.
Equivalent for any other new features in trunk: use trunk with the revision when this new feature was added.
Feedback to new features helps to keep trunk robust (suitable for everyday work).
follow-up: 5 comment:4 by , 6 years ago
Avoiding to open a new ticket, the https://grass.osgeo.org/grass75/manuals/variables.html#list-of-selected-(grass-related)-shell-environment-variables deserves an update. It does not mention anything about ZSTD.
comment:5 by , 6 years ago
Replying to Nikos Alexandris:
Avoiding to open a new ticket, the https://grass.osgeo.org/grass75/manuals/variables.html#list-of-selected-(grass-related)-shell-environment-variables deserves an update. It does not mention anything about ZSTD.
Thanks for the hint, done in trunk r72784. ZSTD is already mentioned in the G7:rasterintro and in the manual of G7:r.compress.
comment:6 by , 6 years ago
| Milestone: | 7.4.1 → 7.4.2 |
|---|
comment:7 by , 6 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Since G7.6.0 is meanwhile slowly on the way (relbranch76 is available) closing as wontfix.
Replying to neteler:
IMHO ZSTD compression is not a backport candidate because it is a new feature. Moreover, substantial changes were introduced to both the gis and raster library, which are in no way a bugfix, disqualifying it for backporting.