Opened 20 months ago

Closed 20 months ago

Last modified 19 months ago

#3496 closed defect (fixed)

v.in.pdal: does not compile with PDAL 1.6.0

Reported by: felixg Owned by: grass-dev@…
Priority: normal Milestone: 7.4.1
Component: Vector Version: svn-releasebranch74
Keywords: v.in.pdal, PDAL, lidar Cc:
CPU: Unspecified Platform: Unspecified

Description

As the PDAL API changed in a few places, the code of v.in.pdal fails to compile and needs to be adjusted.

The attached patch file changes the following in main.cpp of v.in.pdal:

  • the includes as PDAL relocated some header files
  • use of the enum pdal::Dimension::Id
  • a method call to pdal::SpatialReference::getWKT(), it does not have any formal parameters anymore in PDAL

Attachments (1)

fix-for-pdal-vector-import.patch (3.5 KB) - added by felixg 20 months ago.

Download all attachments as: .zip

Change History (7)

Changed 20 months ago by felixg

comment:1 Changed 20 months ago by wenzeslaus

In 72246:

v.in.pdal: change API calls to PDAL 1.6.0, see #3496 and #2732 (author: felixg)

comment:2 Changed 20 months ago by wenzeslaus

Thank you. I committed the change in r72246. Tested with 1.5.0 and 1.6.0 (compiled) and trunk using the two tests in testsuite directory:

export LD_LIBRARY_PATH="/home/.../install/lib:$LD_LIBRARY_PATH"
cd vector/v.in.pdal/testsuite
../../../bin.x86_64-pc-linux-gnu/grass75 ~/grassdata/nc_basic_spm_grass7/user1/ \
    --exec python basic_test.py
../../../bin.x86_64-pc-linux-gnu/grass75 ~/grassdata/nc_basic_spm_grass7/user1/ \
    --exec python filter_test.py

This can be closed after backport to 7.4 (and maybe 7.2).

comment:3 Changed 20 months ago by neteler

In 72253:

v.in.pdal: change API calls to PDAL 1.6.0, see #3496 and #2732 (author: felixg, trunk r72246) + GPL header added in r72245

comment:4 Changed 20 months ago by neteler

Milestone: 7.4.1
Version: unspecifiedsvn-releasebranch74

Replying to wenzeslaus: ...

This can be closed after backport to 7.4 (and maybe 7.2).

Backported to 7.4 in r72253, closing.

@felixg: thanks for the patch!

comment:5 Changed 20 months ago by neteler

Resolution: fixed
Status: newclosed

comment:6 Changed 19 months ago by wenzeslaus

In 72363:

v.in.pdal: change API calls to PDAL 1.6.0, see #3496, #3243, #3101, #2732 (author: felixg, backport of trunk r72246) + GPL header added in r72245

Note: See TracTickets for help on using tickets.