Opened 8 years ago
Closed 7 years ago
#3343 closed defect (fixed)
v.label.sa broken and duplicated in trunk and addons
Reported by: | wenzeslaus | Owned by: | |
---|---|---|---|
Priority: | trivial | Milestone: | 7.4.0 |
Component: | Addons | Version: | svn-trunk |
Keywords: | v.label.sa, FTLIB, FreeType, compilation | Cc: | |
CPU: | Unspecified | Platform: | Unspecified |
Description
v.label.sa code is both in trunk and in addons repository. The versions are the same except for few characters. The compilation is disabled in trunk and it is broken in addons with:
labels.c: In function ‘labels_init’: labels.c:88:5: error: implicit declaration of function ‘find_font_from_freetypecap’ [-Werror=implicit-function-declaration] labels.c:88:14: warning: assignment makes pointer from integer without a cast [enabled by default] labels.c:100:5: error: implicit declaration of function ‘free_fontcap’ [-Werror=implicit-function-declaration]
In G6 the compilation is conditional:
REQUIRESFT = v.label.sa ifneq ($(strip $(FTLIB)),) SUBDIRS += $(REQUIRESFT) endif
and the v.label.sa
code in G6 contains the missing function find_font_from_freetypecap()
.
The free_fontcap
function is in lib/driver/driverlib.h
in G7.
I suggest to remove the trunk version. Fixing the code would be nice of course.
Note:
See TracTickets
for help on using tickets.
Replying to wenzeslaus:
With r71061, the compile errors in
v.label.sa
are fixed and the versions in trunk and addons have been sync'ed.