Opened 8 years ago
Last modified 6 years ago
#3169 new enhancement
use external shapelib
| Reported by: | opoplawski | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.6.2 |
| Component: | Database | Version: | svn-releasebranch72 |
| Keywords: | shapelib, OGR | Cc: | |
| CPU: | Unspecified | Platform: | Unspecified |
Description
Is there any reason at this point to not compile against an external shapelib?
Change History (10)
comment:1 by , 8 years ago
follow-up: 3 comment:2 by , 8 years ago
| Component: | Default → LibVector |
|---|---|
| Keywords: | shapelib OGR added |
| Milestone: | 7.0.5 → 7.2.1 |
| Version: | 7.0.4 → svn-releasebranch72 |
Replying to opoplawski:
Is there any reason at this point to not compile against an external shapelib?
AFAIR we picked shapelib many years ago from http://shapelib.maptools.org/ (points to http://download.osgeo.org/shapelib/). The last release appears to be from 2012 since it then became part of OGR (https://trac.osgeo.org/gdal/browser/branches/2.1/gdal/ogr/ogrsf_frmts/shape).
Here is what we changed after that (for some years we kept it in sync with OGR, then lost track due to the needed effort). For the procedure, see https://trac.osgeo.org/grass/browser/grass/trunk/lib/external/shapelib/README
The real question is: cannot we call the shape driver via OGR interface and drop our own copy?
comment:3 by , 8 years ago
| Component: | LibVector → Database |
|---|
Replying to neteler:
Replying to opoplawski:
Is there any reason at this point to not compile against an external shapelib?
AFAIR we picked shapelib many years ago from http://shapelib.maptools.org/ (points to http://download.osgeo.org/shapelib/). The last release appears to be from 2012 since it then became part of OGR (https://trac.osgeo.org/gdal/browser/branches/2.1/gdal/ogr/ogrsf_frmts/shape).
Here is what we changed after that (for some years we kept it in sync with OGR, then lost track due to the needed effort). For the procedure, see https://trac.osgeo.org/grass/browser/grass/trunk/lib/external/shapelib/README
The real question is: cannot we call the shape driver via OGR interface and drop our own copy?
GRASS needs lib/external/shapelib to read and write dbf files. We can not use the OGR interface easily without rewriting db/drivers/dbf because shapefil.h is not installed with OGR. Also, GRASS does not need the full shapelib, only those parts relevant for dbf RW. An external shapelib is usually not installed because shapefiles can be accessed with the generic OGR interface.
comment:4 by , 8 years ago
| Milestone: | 7.2.1 → 7.2.2 |
|---|
comment:5 by , 7 years ago
| Milestone: | 7.2.2 → 7.4.0 |
|---|
All enhancement tickets should be assigned to 7.4 milestone.
comment:7 by , 7 years ago
| Milestone: | 7.4.1 → 7.4.2 |
|---|
comment:8 by , 6 years ago
| Milestone: | 7.4.2 → 7.6.0 |
|---|
All enhancement tickets should be assigned to 7.6 milestone.
See also issue #1318