"Quit GRASS GIS" button only exits GUI

[cmbarton]

For some time, quitting GRASS from the GUI opens a dialog (see attached) with buttons to "Close GUI" and "Quit GRASS GIS".

But both do the same thing: quitting the GUI but not exiting GRASS. At least that is what happens on the Mac. Is this the case on other platforms too?

[cmbarton]

Quit GRASS dialog

[annakrat]

Yes, other platforms work.

[martinl]

Still relevant?

[cmbarton]

Yes. Quit GRASS button does not work on the Mac

[nila]

This is still an issue with 7.8 branch and master (7.9.dev), with Python 3.8.2 and wxPython 4.0.7.post2.

[nila]

I believe I have found the cause of this issue.

In gui/wxpython/lmgr/frame.py:2533-2536 GMFrame.OnCloseWindowOrExit():

        if ret != wx.ID_CANCEL:
            self._closeWindow(event)
            if ret == wx.ID_YES:
                self._quitGRASS()

in self._closeWindow self (the GMFrame) will be destroyed and self._quitGRASS will never be reached.

[nila]

I was wrong in my previous assessment.

Now I found the bug and the ​PR#408 may fix this issue.

[annakrat]

Replying to nila:

I believe I have found the cause of this issue.

In gui/wxpython/lmgr/frame.py:2533-2536 GMFrame.OnCloseWindowOrExit():

        if ret != wx.ID_CANCEL:
            self._closeWindow(event)
            if ret == wx.ID_YES:
                self._quitGRASS()

in self._closeWindow self (the GMFrame) will be destroyed and self._quitGRASS will never be reached.

Are you sure this is not the case? It seems like that would be a problem. Not sure what the solution would be, perhaps moving the os.kill to the GMApp OnExit? handler.