Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#2988 closed enhancement (fixed)

Install additional hicolor icon sizes

Reported by: Bas Couwenberg Owned by: grass-dev@…
Priority: normal Milestone: 7.0.4
Component: wxGUI Version: svn-trunk
Keywords: Cc:
CPU: All Platform: Linux

Description

The attached patch and tarball with icons are required for Debian Policy compliance, which requires at least 22x22 PNG icons:

Unless hidden by default, the desktop entry must point to a PNG or SVG icon with a transparent background, providing at least the 22×22 size, and preferably up to 64×64. The icon should be neutral enough to integrate well with the default icon themes. It is encouraged to ship the icon in the default hicolor icon theme directories, or to use an existing icon from the hicolor theme.

Debian Policy Manual 9.6 Menus

The 48x48, 64x64 & SVG icons were already installed, these additional PNG icons are mostly required for DEs which don't support SVG.

Attachments (4)

hicolor-icons.patch (2.9 KB) - added by Bas Couwenberg 20 months ago.
hicolor-icons.tar.gz (60.2 KB) - added by Bas Couwenberg 20 months ago.
grass.svg (10.3 KB) - added by Bas Couwenberg 20 months ago.
grass70-icons.patch (4.3 KB) - added by Bas Couwenberg 20 months ago.
The icons in relbr70 need to be installed as grass70.png, not grass71.png as in trunk.

Download all attachments as: .zip

Change History (12)

Changed 20 months ago by Bas Couwenberg

Attachment: hicolor-icons.patch added

comment:1 Changed 20 months ago by martinl

The inner part of icons should be white (and not transparent), see original png icons and recently updated source:grass/trunk/gui/icons/grass.ico

comment:2 Changed 20 months ago by Bas Couwenberg

The .ico is not installed (because "using different icons can be confusing for the user" according to the comment in the Makefile), and the 48x48 and 64x64 PNG icons also use a transparent background.

A transparent background fits better with different themes especially dark ones where the white icon doesn't fit well. This is in line with the Icon Theme Specification which recommends:

It is recommended that the icons installed in the hicolor theme look neutral, since it is a fallback theme that will be used in combination with some very different looking themes. But if you don't have any neutral icon, please install whatever icon you have in the hicolor theme so that all applications get at least some icon in all themes.

comment:3 in reply to:  2 Changed 20 months ago by martinl

Replying to sebastic:

A transparent background fits better with different themes especially dark ones where the white icon doesn't fit well. This is in line with the Icon Theme Specification which recommends:

I do not agree. Transparent inner part makes the icon almost unreadable on some themes.

comment:4 in reply to:  2 Changed 20 months ago by martinl

Replying to sebastic:

The .ico is not installed (because "using different icons can be confusing for the user" according to the comment in the Makefile), and the 48x48 and 64x64 PNG icons also use a transparent background.

no, see source:grass/trunk/gui/icons/grass-48x48.png

comment:5 Changed 20 months ago by Bas Couwenberg

Ah, your just talking about the filling of the square, not the background.

Please note that the existing SVG icon does not fill the square either, that should be fixed along with the additional icons.

Changed 20 months ago by Bas Couwenberg

Attachment: hicolor-icons.tar.gz added

Changed 20 months ago by Bas Couwenberg

Attachment: grass.svg added

comment:6 Changed 20 months ago by Bas Couwenberg

Have a look at the updated icons, the PNGs in the tarball and the separate SVG now use a white fill for the square.

comment:7 Changed 20 months ago by martinl

Resolution: fixed
Status: newclosed

Thanks, applied in trunk in r68263, r68264. Backported to relbr70 as r68265.

Changed 20 months ago by Bas Couwenberg

Attachment: grass70-icons.patch added

The icons in relbr70 need to be installed as grass70.png, not grass71.png as in trunk.

comment:8 Changed 20 months ago by martinl

Ops, fixed in r68266. Thanks for pinging me.

Note: See TracTickets for help on using tickets.