Opened 4 years ago

Closed 4 years ago

#2769 closed defect (fixed)

v.in.ogr not supporting OFTInteger64 field type

Reported by: zarch Owned by: martinl
Priority: normal Milestone: 7.0.4
Component: Vector Version: svn-trunk
Keywords: v.in.ogr Integer64 Cc: grass-dev@…
CPU: All Platform: Linux

Description

It seems that GRASS does not support vector columns with type int64, in most of the cases this fields are just normal int32.

I've written a small patch that treat this field as normal integer (with a warning). It works without problems on my test file... but I'm not sure about the consequences if a real int64 is met.

What do you think? It is safe to move this changes to trunk?

Attachments (1)

v.in.ogr_OFTInteger64.diff (1.4 KB) - added by zarch 4 years ago.
Patch to treat OFTInteger64 field as OFTInteger64

Download all attachments as: .zip

Change History (8)

Changed 4 years ago by zarch

Attachment: v.in.ogr_OFTInteger64.diff added

Patch to treat OFTInteger64 field as OFTInteger64

comment:1 Changed 4 years ago by martinl

Cc: grass-dev@… added
Component: DefaultVector
Owner: changed from grass-dev@… to martinl
Status: newassigned

comment:2 in reply to:  description Changed 4 years ago by martinl

Replying to zarch:

It seems that GRASS does not support vector columns with type int64, in most of the cases this fields are just normal int32.

I've written a small patch that treat this field as normal integer (with a warning). It works without problems on my test file... but I'm not sure about the consequences if a real int64 is met.

support of int64 will depend on DB driver, eg. SQLite integers can hold whatever you put into it: from a 1-byte char to an 8-byte long long (1). PostgreSQL uses int and bigint (2), ...

(1) http://www.sqlite.org/datatype3.html (2) http://www.postgresql.org/docs/9.4/static/datatype-numeric.html

comment:3 Changed 4 years ago by martinl

Please test r66564.

comment:4 Changed 4 years ago by martinl

Can we close the ticket (with milestone 7.1)?

comment:5 in reply to:  4 Changed 4 years ago by zarch

Replying to martinl:

Can we close the ticket (with milestone 7.1)?

yes, it works for me. Thanks

Pietro

comment:6 Changed 4 years ago by martinl

Milestone: 7.1.07.0.4

Backported to relbr70 in r67742 and r67743. Closing.

Last edited 4 years ago by martinl (previous) (diff)

comment:7 Changed 4 years ago by martinl

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.