Opened 5 years ago

Closed 8 months ago

#2494 closed defect (fixed)

d.vect.thematic broken

Reported by: neteler Owned by: grass-dev@…
Priority: normal Milestone: 7.0.7
Component: Display Version: svn-releasebranch70
Keywords: d.vect.thematic, d.graph, gsoc2016 Cc:
CPU: Unspecified Platform: Linux

Description

Using the NC Example from

http://grass.osgeo.org/grass70/manuals/d.vect.thematic.html#examples

one gets:

... [all ok]...

GRASS 7.1.svn (nc_spm_08_grass7):~ > v.univar -e elev_sample col=diff type=point
number of features with non NULL attribute: 200
number of missing attributes: 0
number of NULL attributes: 0
minimum: -26.8796
maximum: 21.2874
range: 48.167
...

GRASS 7.1.svn (nc_spm_08_grass7):~ > d.mon wx0
GRASS 7.1.svn (nc_spm_08_grass7):~ > d.vect.thematic -l elev_sample column=diff type=point
Thematic map legend for column diff of map elev_sample
Value range: -26.8796 - 21.2874
Mapped by 4 intervals of 12.04175
Color(R:G:B)	Value
============	==========
0:0:255		-26.8796 - 21.2874 
d.vect complete.
85:0:170		-26.8796 - 21.2874 
d.vect complete.
170:0:85		-26.8796 - 21.2874 
d.vect complete.
GRASS 7.1.svn (nc_spm_08_grass7):~ > Command 'd.graph color=black input=/home/neteler/grassdata/nc_spm_08_grass7/user1/.tmp/oboe.localdomain/23342.0' failed
Details: Graph file </home/neteler/grassdata/nc_spm_08_grass7/user1/.tmp/oboe.localdomain/23342.0> not found

The file names are indeed different:

ls /home/neteler/grassdata/nc_spm_08_grass7/user1/.tmp/oboe.localdomain/
23101.0.cmd  23101.0.env  23101.0.ppm.ppm

Change History (13)

comment:1 in reply to:  description ; Changed 5 years ago by mlennert

Replying to neteler:

Using the NC Example from

http://grass.osgeo.org/grass70/manuals/d.vect.thematic.html#examples

one gets:

... [all ok]...

GRASS 7.1.svn (nc_spm_08_grass7):~ > v.univar -e elev_sample col=diff type=point
number of features with non NULL attribute: 200
number of missing attributes: 0
number of NULL attributes: 0
minimum: -26.8796
maximum: 21.2874
range: 48.167
...

GRASS 7.1.svn (nc_spm_08_grass7):~ > d.mon wx0
GRASS 7.1.svn (nc_spm_08_grass7):~ > d.vect.thematic -l elev_sample column=diff type=point
Thematic map legend for column diff of map elev_sample
Value range: -26.8796 - 21.2874
Mapped by 4 intervals of 12.04175
Color(R:G:B)	Value
============	==========
0:0:255		-26.8796 - 21.2874 
d.vect complete.
85:0:170		-26.8796 - 21.2874 
d.vect complete.
170:0:85		-26.8796 - 21.2874 
d.vect complete.
GRASS 7.1.svn (nc_spm_08_grass7):~ > Command 'd.graph color=black input=/home/neteler/grassdata/nc_spm_08_grass7/user1/.tmp/oboe.localdomain/23342.0' failed
Details: Graph file </home/neteler/grassdata/nc_spm_08_grass7/user1/.tmp/oboe.localdomain/23342.0> not found

I see the same message without the '-l' flag and am a bit stumped about where this comes from. In d.vect.thematic.py the only call to d.graph happens if the '-l' flag is set, so this message do not seem to come from the module itself. <wild guess>Could it be the wx0 monitor that tries to call the file after d.vect.thematic itself has closed and erased its temp files ?</wild guess>

Moritz

comment:2 in reply to:  1 ; Changed 4 years ago by lazaa

From the documentation it seems that currently the module d.vect.thematic works only for polygons (type=area data). For point data there is a module in AddOns? d.vect.thematic2. I tried run the module d.vect.thematic2 with a sample of points and everything worked well with no error.

Adam

comment:3 in reply to:  2 ; Changed 4 years ago by neteler

Milestone: 7.0.07.0.5

Replying to lazaa:

From the documentation it seems that currently the module d.vect.thematic works only for polygons (type=area data). For point data there is a module in AddOns? d.vect.thematic2. I tried run the module d.vect.thematic2 with a sample of points and everything worked well with no error.

Interesting! The manual even says: "d.vect.thematic2 creates thematic maps from vector features of all types and numeric attributes stored in the attribute table connected to a vector map." (emphasis is mine).

Perhaps time to merge into trunk and enhance/replace d.vect.thematic?

comment:4 in reply to:  3 ; Changed 4 years ago by martinl

Replying to neteler:

Perhaps time to merge into trunk and enhance/replace d.vect.thematic?

There are two versions:

  • d.vect.thematic in trunk (C module)
  • d.vect.thematic2 in addons (Python)

Please keep C version in trunk and enhance.

comment:5 in reply to:  4 ; Changed 4 years ago by mlennert

Replying to martinl:

Replying to neteler:

Perhaps time to merge into trunk and enhance/replace d.vect.thematic?

There are two versions:

  • d.vect.thematic in trunk (C module)
  • d.vect.thematic2 in addons (Python)

Please keep C version in trunk and enhance.

See also [1] which never received any comments. Maybe this discussion should be part of the general GSoC cartography project ?

[1] https://lists.osgeo.org/pipermail/grass-dev/2015-January/072918.html

comment:6 in reply to:  5 Changed 4 years ago by veroandreo

Keywords: gsoc2016 added

Replying to mlennert:

Replying to martinl:

Replying to neteler:

Perhaps time to merge into trunk and enhance/replace d.vect.thematic?

There are two versions:

  • d.vect.thematic in trunk (C module)
  • d.vect.thematic2 in addons (Python)

Please keep C version in trunk and enhance.

See also [1] which never received any comments. Maybe this discussion should be part of the general GSoC cartography project ?

[1] https://lists.osgeo.org/pipermail/grass-dev/2015-January/072918.html

+1

comment:7 Changed 3 years ago by martinl

Still an issue after GSOC 2016?

comment:8 in reply to:  7 ; Changed 3 years ago by annakrat

Replying to martinl:

Still an issue after GSOC 2016?

The bug is in the Python addon, Adam enhanced the C module (still working on merging the changes). So I guess the bug for the addon is still valid.

comment:9 in reply to:  8 ; Changed 3 years ago by mlennert

Replying to annakrat:

Replying to martinl:

Still an issue after GSOC 2016?

The bug is in the Python addon, Adam enhanced the C module (still working on merging the changes). So I guess the bug for the addon is still valid.

After Adam's improvements, what is still missing in the C module which exists in the python addon ? As soon as the first is feature-compatible with the latter we should remove the addon, instead of maintaining the two.

comment:10 in reply to:  9 Changed 3 years ago by annakrat

Replying to mlennert:

Replying to annakrat:

Replying to martinl:

Still an issue after GSOC 2016?

The bug is in the Python addon, Adam enhanced the C module (still working on merging the changes). So I guess the bug for the addon is still valid.

After Adam's improvements, what is still missing in the C module which exists in the python addon ? As soon as the first is feature-compatible with the latter we should remove the addon, instead of maintaining the two.

the C module can still only work with colors, line width and point size are not implemented there yet.

comment:11 Changed 3 years ago by neteler

Milestone: 7.0.57.0.6

comment:12 Changed 22 months ago by neteler

Milestone: 7.0.67.0.7

comment:13 Changed 8 months ago by martinl

Resolution: fixed
Status: newclosed

Still relevant?

Note: See TracTickets for help on using tickets.