Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#2443 closed defect (fixed)

r.in.srtm.region add-on updates for 7.1svn

Reported by: awickert Owned by: grass-dev@…
Priority: normal Milestone: 7.2.0
Component: Addons Version: unspecified
Keywords: Cc:
CPU: Unspecified Platform: Unspecified

Description

The simplification in GRASS 7.1 that changes g.list/g.mlist and g.mremove into g.list and g.remove for everything broke some of the functionality of r.in.srtm.region. I've attached a revised file and a list of diffs. My changes check for GRASS version, and while I haven't tested it with 7.0, should allow it to work on both 7.0 and 7.1.

I should note that these changes likely broke other add-ons, but that I am in support of the g.list/g.remove change.

Thanks in advance for updating,

Andy Wickert

Attachments (2)

r.in.srtm.region.py (11.4 KB) - added by awickert 5 years ago.
Updated r.in.srtm.region
r.in.srtm.region.diff (3.3 KB) - added by awickert 5 years ago.
diffs

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by awickert

Attachment: r.in.srtm.region.py added

Updated r.in.srtm.region

Changed 5 years ago by awickert

Attachment: r.in.srtm.region.diff added

diffs

comment:1 in reply to:  description Changed 5 years ago by mmetz

Replying to awickert:

The simplification in GRASS 7.1 that changes g.list/g.mlist and g.mremove into g.list and g.remove for everything broke some of the functionality of r.in.srtm.region. I've attached a revised file and a list of diffs. My changes check for GRASS version, and while I haven't tested it with 7.0, should allow it to work on both 7.0 and 7.1.

Thanks for the patch. I have updated r.in.srtm.region in r62451. Note that the default is now to import SRTM v3.

comment:2 Changed 5 years ago by awickert

Resolution: fixed
Status: newclosed

Thanks, Markus! Looks good to me, so I am marking this as "resolved".

comment:3 Changed 4 years ago by neteler

Milestone: 7.1.07.2.0

Milestone renamed

Note: See TracTickets for help on using tickets.