Opened 12 years ago

Closed 6 years ago

Last modified 6 years ago

#222 closed defect (fixed)

v.in gns broken in grass 7.0 trunk

Reported by: gisix Owned by: gisix
Priority: blocker Milestone: 7.0.0
Component: Vector Version: svn-trunk
Keywords: v.in.gns Cc: grass-dev@…
CPU: x86-32 Platform: Linux

Description (last modified by neteler)

v.in.gns aborts when applied to a country file:

GRASS 7.0.svn (wgs84_4326):~/gns > v.in.gns --overwrite file=ce.txt vect=sri
Converted 36554 place names.
WARNUNG: Vector map <sri> already exists and will be overwritten
Scanning input for column types...
Current row: 'RC;UFI;UNI;LAT;LONG;DMS_LAT;DMS_LONG;MGRS;JOG;FC;DSG;PC;CC1;ADM1;ADM2;POP;ELEV;CC2;NT;LC;SHORT_FORM;GENERIC;SORT_NAME;FULL_NAME;FULL_NAME_ND;MODIFY_DATE'
FEHLER: Unparsable latitude value in column <3>: LAT
FEHLER: Unable to open vector map <sri@gns> on topology level 2

Attachments (1)

v_in_gns.diff (1.3 KB) - added by neteler 12 years ago.
GNS format changed patch

Download all attachments as: .zip

Change History (12)

comment:1 Changed 12 years ago by neteler

Description: modified (diff)

Please post the URL to ce.txt.

comment:2 in reply to:  1 Changed 12 years ago by gisix

Owner: changed from grass-dev@… to gisix
Status: newassigned

Replying to neteler:

Please post the URL to ce.txt.

The input file is located here: http://earth-info.nga.mil/gns/html/cntyfile/ce.zip

comment:3 Changed 12 years ago by neteler

Cc: grass-dev@… added

please keep grass-dev in the loop.

comment:4 in reply to:  3 Changed 12 years ago by gisix

Replying to neteler:

please keep grass-dev in the loop.

right.

comment:5 Changed 12 years ago by neteler

Apparently they changed the GNS format :( Attached a hacked patch.

Note that geonames.org most likely provides better data (AFAIK they include GNS).

Markus

Changed 12 years ago by neteler

Attachment: v_in_gns.diff added

GNS format changed patch

comment:6 in reply to:  1 Changed 12 years ago by gisix

Replying to neteler:

Please post the URL to ce.txt.

The patch fixes the problems with the sri lanka file (ce.txt) yet fails for thailand: http://earth-info.nga.mil/gns/html/cntyfile/th.zip

comment:7 Changed 12 years ago by neteler

Description: modified (diff)
Milestone: 6.3.17.0.0

(milestone tag fixed)

I am not sure how to address this problem if the GNS format is a moving target...

Markus

comment:8 Changed 7 years ago by mlennert

Priority: majornormal

No one has touched this report for 5 years and the code has not changed significantly.

I just tried with 8 different gns country files and only 2 worked.

As this is only a convenience script around v.in.ascii, I propose to deprecate this module and take it out of trunk and/or move it to addons.

In any case, while waiting for opinions, I'm downgrading this to normal.

Moritz

comment:9 Changed 6 years ago by neteler

Priority: normalblocker

I agree that v.in.gns should be moved to Addons (superseded by v.in.geonames).

See http://grasswiki.osgeo.org/wiki/GRASS_7_ideas_collection#Dead_code_cleanup

comment:10 in reply to:  9 ; Changed 6 years ago by lucadelu

Resolution: fixed
Status: assignedclosed

Replying to neteler:

I agree that v.in.gns should be moved to Addons (superseded by v.in.geonames).

See http://grasswiki.osgeo.org/wiki/GRASS_7_ideas_collection#Dead_code_cleanup

I fixed it with the last version of GNS in r62900, I'm able to load all the txt files inside the th.zip.

I also moves the script to addons r62902 (it is possible to install it using g.extension).

comment:11 in reply to:  10 Changed 6 years ago by neteler

Replying to lucadelu:

I also moves the script to addons r62902 (it is possible to install it using g.extension).

Since it is a functional addon now, removed from relbranch70 in r63648.

Note: See TracTickets for help on using tickets.