Opened 9 years ago

Last modified 5 years ago

#1785 new defect

r.param.scale module source code error ?

Reported by: jprigol Owned by: grass-dev@…
Priority: normal Milestone: 6.4.6
Component: Raster Version: svn-releasebranch64
Keywords: r.param.scale, feature.c Cc:
CPU: Unspecified Platform: Unspecified

Description (last modified by neteler)

Hi.

I've been looking trhough r.param.scale source code. The point is that I was wondering if there was an error in file http://trac.osgeo.org/grass/browser/grass/trunk/raster/r.param.scale/feature.c

The last "else if... (line 103)" includes two simultaneous conditions that should (?) have opposite comparison operations (in addition, it never will take place because the root "if" has the same condition), i.e.

"else if (minic < curve_tol && minic > -curve_tol) {"

Then, final "return (FLAT) (line 108)" will be useless (?).

Kind regards, Juan

-- Atentamente, Juan P. Rigol-Sánchez Recursos Hídricos y Geología Ambiental Dpto. Hidrogeología y Química Analítica Universidad de Almería - España (Spain, EU)

Change History (2)

comment:1 Changed 8 years ago by neteler

Description: modified (diff)
Milestone: 6.4.36.4.4
Version: unspecifiedsvn-releasebranch64

comment:2 Changed 5 years ago by neteler

Milestone: 6.4.46.4.6
Note: See TracTickets for help on using tickets.