Opened 8 years ago

Closed 8 years ago

#1543 closed defect (fixed)

WXGUI GDAL/OGR import dialogs fail to open in WinGRASS

Reported by: marisn Owned by: martinl
Priority: blocker Milestone: 6.5.0
Component: wxGUI Version: svn-releasebranch64
Keywords: wingrass, wxpython 2.8.12.1 Cc: grass-dev@…
CPU: Unspecified Platform: MSWindows Vista

Description

WinGRASS-6.4.SVN-r50399-1-Setup on Vista selecting import raster/vector from wxgui results in following error:

Traceback (most recent call last):
  File "c:/Program Files/GRASS
6.4.SVN/etc/wxpython/wxgui.py", line 1137, in
OnImportGdalLayers

dlg = gdialogs.GdalImportDialog(parent = self)
  File "c:\Program Files\GRASS
6.4.SVN\etc\wxpython\gui_modules\gdialogs.py", line 1251, in
__init__

self.dsnInput = gselect.GdalSelect(parent = self, panel =
self.panel, ogr = ogr)
  File "c:\Program Files\GRASS
6.4.SVN\etc\wxpython\gui_modules\gselect.py", line 1155, in
__init__

ogr = ogr)
  File "c:\Program Files\GRASS
6.4.SVN\etc\wxpython\gui_modules\gselect.py", line 957, in
__init__

style = wx.CB_READONLY, **kwargs)
  File "C:\Program Files\GRASS 6.4.SVN\Python27\lib\site-
packages\wx-2.8-msw-unicode\wx\_controls.py", line 494, in
__init__

_controls_.Choice_swiginit(self,_controls_.new_Choice(*args,
**kwargs))
wx._core
.
PyAssertionError
:
C++ assertion "!(style & wxCB_DROPDOWN) && !(style &
wxCB_READONLY) && !(style & wxCB_SIMPLE)" failed at
..\..\src\msw\choice.cpp(121) in wxChoice::Create(): this
style flag is ignored by wxChoice, you probably want to use
a wxComboBox
Traceback (most recent call last):
  File "c:/Program Files/GRASS
6.4.SVN/etc/wxpython/wxgui.py", line 1149, in
OnImportOgrLayers

dlg = gdialogs.GdalImportDialog(parent = self, ogr = True)
  File "c:\Program Files\GRASS
6.4.SVN\etc\wxpython\gui_modules\gdialogs.py", line 1251, in
__init__

self.dsnInput = gselect.GdalSelect(parent = self, panel =
self.panel, ogr = ogr)
  File "c:\Program Files\GRASS
6.4.SVN\etc\wxpython\gui_modules\gselect.py", line 1155, in
__init__

ogr = ogr)
  File "c:\Program Files\GRASS
6.4.SVN\etc\wxpython\gui_modules\gselect.py", line 957, in
__init__

style = wx.CB_READONLY, **kwargs)
  File "C:\Program Files\GRASS 6.4.SVN\Python27\lib\site-
packages\wx-2.8-msw-unicode\wx\_controls.py", line 494, in
__init__

_controls_.Choice_swiginit(self,_controls_.new_Choice(*args,
**kwargs))
wx._core
.
PyAssertionError
:
C++ assertion "!(style & wxCB_DROPDOWN) && !(style &
wxCB_READONLY) && !(style & wxCB_SIMPLE)" failed at
..\..\src\msw\choice.cpp(121) in wxChoice::Create(): this
style flag is ignored by wxChoice, you probably want to use
a wxComboBox

As this can be considered a core functionality, blocking release till it's fixed.

Change History (9)

comment:1 Changed 8 years ago by martinl

Keywords: wxpython 2.8.12.1 added

Related to OSGeo4W Python 2.5 -> 2.7 switch, or better to say to the new wxpython package (2.8.12.1). Try to investigate more...

comment:2 Changed 8 years ago by neteler

Was it file or directory import (which switch button in the GUI)? This may make a difference.

comment:3 in reply to:  2 Changed 8 years ago by martinl

Replying to neteler:

Was it file or directory import (which switch button in the GUI)? This may make a difference.

The dialog doesn't start at all. Some mismatch in wxWidgets libraries, try to fix it.

comment:4 Changed 8 years ago by martinl

Cc: grass-dev@… added
Owner: changed from grass-dev@… to martinl
Status: newassigned

Hopefully fixed in r50408

comment:5 Changed 8 years ago by martinl

Milestone: 6.4.26.5.0

Tested with the lasted build (1) - seems to work.

Please backport fix to devbr6/trunk. Thanks.

(1) http://wingrass.fsv.cvut.cz/grass64/WinGRASS-6.4.SVN-r50414-1-Setup.exe

comment:6 Changed 8 years ago by neteler

A diff shows that r50408 is already present in 6.5.

comment:7 Changed 8 years ago by neteler

I tested with WinGRASS-6.4.SVN-r50414-1-Setup.exe, the single file importer works again (raster tested).

comment:8 in reply to:  6 Changed 8 years ago by martinl

Replying to neteler:

A diff shows that r50408 is already present in 6.5.

it has been fixed in 6.5 - r50409

comment:9 Changed 8 years ago by martinl

Resolution: fixed
Status: assignedclosed

Closing, feel free to re-open if needed.

Note: See TracTickets for help on using tickets.