Opened 11 years ago

Closed 8 years ago

#1400 closed defect (fixed)

preferences apply doesn't seem to do anything

Reported by: cmbarton Owned by: grass-dev@…
Priority: normal Milestone: 6.4.2
Component: wxGUI Version: unspecified
Keywords: preferences Cc:
CPU: OSX/Intel Platform: MacOSX

Description

Pressing the apply button in preferences seems to have no effect on the current session.

Change History (13)

comment:1 by martinl, 11 years ago

It should, can you give an example?

comment:2 by cmbarton, 11 years ago

I went to test this and I cannot do so because the settings dialog is modal in GRASS 6.4.2. So I can't tell if any setting changes are sticking when I press the "apply" button. Because I cannot exit the settings dialog to check until I press OK.

Michael

in reply to:  2 ; comment:3 by martinl, 11 years ago

Replying to cmbarton:

I went to test this and I cannot do so because the settings dialog is modal in GRASS 6.4.2. So I can't tell if any setting changes are sticking when I press the "apply" button. Because I cannot exit the settings dialog to check until I press OK.

are you speaking about GUI Settings dialog? There is no OK button, only Cancel, Apply and Save. Dialog is not modal, and Apply closes the dialog.

in reply to:  3 ; comment:4 by hamish, 11 years ago

Replying to martinl:

There is no OK button, only Cancel, Apply and Save. Dialog is not modal, and Apply closes the dialog.

so IIUC [Apply] uses the new settings without saving to the wxrc? I was wondering about that. which leads to the question of why call it "Apply" and not "Ok"? (I think Apply is kinda weird in most software, nothing grass specific)

shrug, Hamish

in reply to:  3 ; comment:5 by cmbarton, 11 years ago

Replying to martinl:

Replying to cmbarton:

I went to test this and I cannot do so because the settings dialog is modal in GRASS 6.4.2. So I can't tell if any setting changes are sticking when I press the "apply" button. Because I cannot exit the settings dialog to check until I press OK.

are you speaking about GUI Settings dialog? There is no OK button, only Cancel, Apply and Save. Dialog is not modal, and Apply closes the dialog.

I meant "save" instead of "OK".

This settings dialog is modal in GRASS 6.4.2 so I cannot test whether or not the settings are applied or not without saving.

Michael

in reply to:  4 comment:6 by cmbarton, 11 years ago

Replying to hamish:

Replying to martinl:

There is no OK button, only Cancel, Apply and Save. Dialog is not modal, and Apply closes the dialog.

so IIUC [Apply] uses the new settings without saving to the wxrc?

Right. That's how it's supposed to work AFAIK. That way you can make some settings for the current session but not have to save them for future sessions.

I was wondering about that. which leads to the question of why call it "Apply" and not "Ok"? (I think Apply is kinda weird in most software, nothing grass specific)

shrug, Hamish

The second, somewhat related use of "apply" is so that you can change some parameters from a dialog and not have the dialog close (which is often the default behavior when the "OK" or similar button is pressed).

in reply to:  5 comment:7 by martinl, 11 years ago

Replying to cmbarton:

This settings dialog is modal in GRASS 6.4.2 so I cannot test whether or not the settings are applied or not without saving.

why the modal dialog is problem? When you press button 'Apply', the settings is stored for current session and the dialog is closed.

in reply to:  4 comment:8 by martinl, 11 years ago

Reporter: changed from cmbarton to digit,cmbarton

Replying to hamish:

so IIUC [Apply] uses the new settings without saving to the wxrc?

yes, similarly behaves other settings dialogs (vdigit, 3dview, georectifier).

I was wondering about that.

why? Check button's tooltip:

self.btnApply.Bind(wx.EVT_BUTTON, self.OnApply)
self.btnApply.SetToolTipString(_("Apply changes for the current session"))
self.btnSave.Bind(wx.EVT_BUTTON, self.OnSave)
self.btnSave.SetToolTipString(_("Apply and save changes to user settings file (default for next sessions)"))

which leads to the question of why call it "Apply" and not "Ok"? (I think Apply is kinda weird in most software, nothing grass specific)

Why OK rather then Apply? Apply seems to be more appropriate for this functionality.

comment:9 by martinl, 11 years ago

Reporter: changed from digit,cmbarton to cmbarton

comment:10 by cmbarton, 11 years ago

In most cases, including in many or most GRASS cases, pressing "apply" allows the dialog to remain open non-modally to do something with the new settings of whatever apply works with.

I did some spot checking.

The following items changed in settings also show up in the current GRASS session when the "apply" button is pressed. -ask when removing map from layer tree -expand all (element list) -status bar mode (need to open a new display for this to register)

The following items changed do not show up in the current GRASS session with "apply" and only show up when the "save" button is pressed. -command font (NB: only some fonts, maybe only 2, show up even with "save"; but font size always affected by "save") -display font -close dialog when command is successfully finished

comment:11 by cmbarton, 11 years ago

Here is a reformatting of my results for easier reading

The following items changed in settings also show up in the current GRASS session when the "apply" button is pressed.

-ask when removing map from layer tree -expand all (element list)
-status bar mode (need to open a new display for this to register)

The following items changed do not show up in the current GRASS session with "apply" and only show up when the "save" button is pressed.

-command font (NB: only some fonts, maybe only 2, show up even with "save"; but font size always affected by "save")
-display font
-close dialog when command is successfully finished

comment:12 by cmbarton, 10 years ago

This is now working on the Mac. On other platforms? Maybe we can close.

Michael

in reply to:  12 comment:13 by wenzeslaus, 8 years ago

Resolution: fixed
Status: newclosed

Replying to cmbarton:

This is now working on the Mac. On other platforms? Maybe we can close.

No further problems reported, closing. If there will be some problems, please open new specific tickets.

Note: See TracTickets for help on using tickets.