Changeset 68396

Timestamp:

May 7, 2016, 11:52:46 AM (8 years ago)

Author:

wenzeslaus

Message:

pyedit: do not use onDone because it is not executed when GUI is invoked (fixes #2997)

Now you can run again even if it is already running
which is the same behavior as for normal module calls.

It also uses the same temporary file once it was created
to avoid the need to delete it all the time. It is deleted
when file is actually saved.

Also remove suppression of the GUI interface because we
actually want to get GUI (the parameter does not work, r68395).

File:

• grass/trunk/gui/wxpython/gui_core/pyedit.py (modified) (3 diffs)

grass/trunk/gui/wxpython/gui_core/pyedit.py

@@ -260 +260 @@
         self.filename = None
         self.tempfile = None  # bool, make them strings for better code
-        self.running = False
 
     def OnRun(self, event):
         """Run Python script"""
-        if self.running:
-            # ignore when already running
-            return
-
         if not self.filename:
             self.filename = gscript.tempfile() + '.py'
@@ -295 +290 @@
         # run in console as other modules, avoid Python shell which
         # carries variables over to the next execution
-        self.giface.RunCmd([fd.name], skipInterface=True, onDone=self.OnDone)
-        self.running = True
-
-    def OnDone(self, event):
-        """Python script finished"""
+        self.giface.RunCmd([fd.name])
+
+    def SaveAs(self):
+        """Save python script to file"""
         if self.tempfile:
             try_remove(self.filename)
-            self.filename = None
-        self.running = False
-
-    def SaveAs(self):
-        """Save python script to file"""
-        filename = ''
+            self.tempfile = False
+
+        filename = None
         dlg = wx.FileDialog(parent=self.guiparent,
                             message=_("Choose file to save"),
@@ -358 +349 @@
         Just save if file already specified, save as action otherwise.
         """
-        if self.filename:
+        if self.filename and not self.tempfile:
             self.Save()
         else: