Changes between Initial Version and Version 1 of Ticket #951, comment 1


Ignore:
Timestamp:
Sep 20, 2019, 11:10:02 AM (5 years ago)
Author:
pramsey

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #951, comment 1

    initial v1  
    1 Yeah, moving to stack-allocation means that all the JTS checks on ptr == null end up being function calls in GEOS land. The function is already part of the GEOS inlining code. The only thing my small brain thinks of is an actual boolean member, so that the function call can be replaced with a look at a value instead, at the cost of a little extra memory.
     1I ran Instruments.app against a Release build and I'm not seeing heavy use of isNull(). The heaviest stack ends on SegmentNode::compareTo()