Opened 18 years ago

Last modified 15 years ago

#92 closed defect

MarkupSTL.cpp - always true comparison — at Initial Version

Reported by: mateusz@… Owned by: strk@…
Priority: major Milestone: 3.2.0
Component: tests Version: 2.2.2
Severity: Content Keywords: imported, phpbugtracker
Cc:

Description

g++ with -pedantic option reports following warning that may significantly influence logic of this code:

/home/mloskot/dev/geos/_cvs/geos/tests/xmltester/markup/MarkupSTL.cpp:884: warning: comparison is always true due to limited range of data type

Here is this comparison:
int nEndCDATA = m_strDoc.find( "]]>",
                  token.nNext );
if ( (unsigned int)nEndCDATA != string::npos
&amp;&amp; nEndCDATA < m_aPos[iPos].nEndL )
{
   return m_strDoc.substr(token.nL+9,
          nEndCDATA-token.nL-9 );
}

Change History (0)

Note: See TracTickets for help on using tickets.