Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#804 closed defect (fixed)

tut_result.hpp needs includes for getpid

Reported by: goatbar Owned by: mloskot
Priority: major Milestone: 3.6.2
Component: Default Version: 3.6.0
Severity: Unassigned Keywords:
Cc:

Description

It would be good to also wrap parts of tut_result.hpp in HAVE_SYS_TYPES_H, HAVE_UNISTD, and/or TUT_USE_POSIX. e.g. like tut_console_reporter.hpp

Change History (14)

comment:1 by strk, 6 years ago

TUT is a local copy of this upstream: http://mrzechonek.github.io/tut-framework/

Could you report the bug there, and then we pull a copy when ready ?

comment:3 by mloskot, 5 years ago

Owner: changed from geos-devel@… to mloskot

comment:4 by mloskot, 5 years ago

Milestone: 3.7.03.6.2

comment:5 by mloskot, 5 years ago

Resolution: fixed
Status: newclosed

Fixed in svn-3.6: https://git.osgeo.org/gogs/geos/geos/commit/17e0d841b5f433037c7f8a00855ea7a97a3bac1f

Fixed in svn-trunk: https://git.osgeo.org/gogs/geos/geos/commit/ee134e7af15898a2cc6631d046851b50523cf437

(p.s. I have no idea if Trac automatically recognises Fixes #XXX and updates tickets)

comment:6 by strk, 5 years ago

Trac should recognize "Fixes #xxxx" in commit logs, yes. And I think you can reference commits with something like this: [17e0d84/git]

comment:7 by strk, 5 years ago

Ok the commit log parsing isn't working and the commit reference link I forgot how to make it, let's please file a ticket for the ticket update via commit log, must be a non-working git hook

comment:8 by strk, 5 years ago

Ok this works for commit reference: changeset:17e0d84/git

The syntax with [17e0d84/git] does not. I filed an upstream ticket about this: https://trac.edgewall.org/ticket/12760

comment:9 by strk, 5 years ago

For the record, using at least 8 characters in this TracLink form works: [17e0d841/git] See https://trac.edgewall.org/ticket/11992#comment:10

comment:10 by strk, 5 years ago

Mateusz I've updated the git post-receive hook so that hopefully now ticket updates via commit logs work. If you still find them to be non-working please file a ticket either here on trac OR on the now-under-git hooks repo: https://git.osgeo.org/gogs/geos/geos-git-hooks.git (private)

comment:11 by mloskot, 5 years ago

Sandro, OK, I will

comment:12 by Mateusz Loskot <mateusz@…>, 5 years ago

In ee134e7/git:

Update TUT to latest release 2016-12-19.

Source: https://github.com/mrzechonek/tut-framework/releases/tag/2016-12-19

Fixes #639
Fixes #804

comment:13 by Mateusz Loskot <mateusz@…>, 5 years ago

In ee134e7/git:

Update TUT to latest release 2016-12-19.

Source: https://github.com/mrzechonek/tut-framework/releases/tag/2016-12-19

Fixes #639
Fixes #804

comment:14 by Mateusz Loskot <mateusz@…>, 5 years ago

In ee134e7/git:

Update TUT to latest release 2016-12-19.

Source: https://github.com/mrzechonek/tut-framework/releases/tag/2016-12-19

Fixes #639
Fixes #804

Note: See TracTickets for help on using tickets.