Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#799 closed defect (fixed)

Need a std:: prefix for fabs in MinimumDiameter.cpp

Reported by: hobu Owned by: geos-devel@…
Priority: trivial Milestone: 3.6.1
Component: Default Version: 3.6.0
Severity: Unassigned Keywords:
Cc:

Description

A simple patch that might matter for some compilers.

Attachments (1)

fabs.patch​ (1.8 KB ) - added by hobu 7 years ago.

Download all attachments as: .zip

Change History (9)

by hobu, 7 years ago

Attachment: fabs.patch​ added

comment:1 by strk, 7 years ago

I guess the C++ templated "abs" could be used instead, have you tried that ?

comment:2 by strk, 7 years ago

In 4319:

Include <cmath> for fabs use, see #799

comment:3 by strk, 7 years ago

Could you please test r4319 with your compiler and let me know if it works ?

comment:4 by hobu, 7 years ago

Looks good. Thanks.

comment:5 by strk, 7 years ago

Resolution: → fixed
Status: new → closed

In 4327:

Fix build for android-ndk

Closes #799 (and #802)

comment:6 by Sandro Santilli <strk@…>, 7 years ago

In f6c023c/git:

Include <cmath> for fabs use, see #799

git-svn-id: ​http://svn.osgeo.org/geos/trunk@4319 5242fede-7e19-0410-aef8-94bd7d2200fb

comment:7 by Sandro Santilli <strk@…>, 7 years ago

In f6c023c/git:

Include <cmath> for fabs use, see #799

git-svn-id: ​http://svn.osgeo.org/geos/trunk@4319 5242fede-7e19-0410-aef8-94bd7d2200fb

comment:8 by Sandro Santilli <strk@…>, 7 years ago

In f6c023c/git:

Include <cmath> for fabs use, see #799

git-svn-id: ​http://svn.osgeo.org/geos/trunk@4319 5242fede-7e19-0410-aef8-94bd7d2200fb

Note: See TracTickets for help on using tickets.