Opened 7 years ago

Closed 7 years ago

#636 closed defect (fixed)

LineSegmentIndex = operator missing a return

Reported by: goatbar Owned by: geos-devel@…
Priority: major Milestone: 3.3.9
Component: Default Version: 3.3.8
Severity: Unassigned Keywords:
Cc: warmerdam

Description

geos-3.3.8/src/simplify/LineSegmentIndex.cpp:87:2: error: control may reach end of non-void function [-Werror,-Wreturn-type]

Probably should be fixed by adding a return *this; to the end of the equals operator.

	LineSegmentVisitor& operator=(const LineSegmentVisitor& o)
	{
		if ( this == &o ) return *this;
		querySeg = o.querySeg;
		items.reset(new vector<LineSegment*>(*(o.items.get())));
                return *this;  // <-- missing line
	}

Change History (1)

comment:1 Changed 7 years ago by strk

Milestone: 3.3.9
Resolution: fixed
Status: newclosed

Thanks, fixed with r3843 in 3.3 branch and r3844 in trunk

Note: See TracTickets for help on using tickets.