Opened 12 years ago

Closed 12 years ago

#513 closed defect (fixed)

Fix PHP 5.4 compatibility

Reported by: voxik Owned by: geos-devel@…
Priority: major Milestone: 3.3.4
Component: Default Version: 3.3.3
Severity: Unassigned Keywords:
Cc: jmckenna

Description

The attached patch fixes compatibility with PHP 5.4.

Please note that I just fixed the build errors, however I did not tested the functionality.

Attachments (1)

geos-3.3.2-php-5.4.patch​ (2.7 KB ) - added by voxik 12 years ago.

Download all attachments as: .zip

Change History (6)

by voxik, 12 years ago

Attachment: geos-3.3.2-php-5.4.patch​ added

comment:1 by strk, 12 years ago

Running "make check" should do the testing for you.

comment:2 by jmckenna, 12 years ago

Cc: jmckenna added

comment:3 by voxik, 12 years ago

Actually, checking the build log [1], it seems that some tests were executed, so hopefully it works ;)

[1] ​http://kojipkgs.fedoraproject.org/packages/geos/3.3.2/2.fc17/data/logs/x86_64/build.log

comment:4 by strk, 12 years ago

Milestone: 3.3.3 → 3.3.4
Version: 3.3.2 → 3.3.3

comment:5 by strk, 12 years ago

Resolution: → fixed
Status: new → closed

Please try r3624 (in 3.3 branch) or r3625 (in trunk). I've slightly modified the patch to have less #ifdefs -- didn't handle to simplify the object_properties_init vs. zend_hash_copy using a macro, if you can I'm ready to update (and test on PHP 5.3)

Note: See TracTickets for help on using tickets.