Opened 13 years ago

Closed 11 years ago

#325 closed task (wontfix)

there is no destroy function for CoordinateSequence

Reported by: aharon Owned by: geos-devel@…
Priority: blocker Milestone:
Component: Default Version: main
Severity: Unassigned Keywords:
Cc:

Description

we can create CoordinateSequence by CoordinateSequenceFactory::Creae but, there is no way to distroy the creaed CoordinteSequence. also there is no way to create/distroy std::vector<Geomtry> .

Change History (4)

comment:1 by aharon, 13 years ago

we can create Coordinate Sequence by CoordinateSequenceFactory::Creae but, there is no way to distroy the creaed Coordinte Sequence. also there is no way to create/distroy std::vector<Geomtry> .

comment:2 by mloskot, 13 years ago

I can confirm there is not named destructor provided for the CoordinateSequence and related types. Amazingly, I have no idea myself why it's missing or even how it is supposed to be designed.

Sandro, Paul, is it intentional?

comment:3 by aharon, 13 years ago

I think that it suppose to be in CoordinateSequenceFactory like it is in GeometryFactory. GeometryFactory has createGeometry and also distroyGeometry.

what about creator for std::vector<Geometry>? it is strongly necessary.

comment:4 by strk, 11 years ago

Resolution: wontfix
Status: newclosed

In JTS GeometryFactory is a class while CoordinateSequenceFactory is an interface. In JTS neither GeometryFactory nor CoordinateSequenceFactory have a destroy function.

Anyway, if you feel like it'd be needed, you can provide a patch, but there's currently not much such functions would do beside simply using delete against the object, and unless you prevent directly using 'delete' I don't see much point in exposing an interface hiding that part.

Note: See TracTickets for help on using tickets.